1646803 - The parent process' main thread doesn't have a name

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Florian Quèze [:florian]]

In about:processes, the main thread of the parent process doesn't have a name and is shown as '???'.

For child processes, the MainThread name is set at https://searchfox.org/mozilla-central/rev/5e6c7717255ca9638b2856c2b2058919aec1d21d/toolkit/xre/nsEmbedFunctions.cpp#340
We need to do something equivalent for the parent.

Comment 1

[Andrew McCreight [:mccr8]]

I think the equivalent function for the parent process is XRE_InitParentProcess().

Comment 2

[Florian Quèze [:florian]]

I tried adding NS_SetCurrentThreadName("MainThread"); in XRE_InitParentProcess right after the NS_SetMainThread(); line but that didn't change the name in about:processes.

When I add NS_SetCurrentThreadName("MainThread"); in XRE_main the name is displayed in about:processes.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1646803 - name the parent process main thread, r=mccr8.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f8a59996994
name the parent process main thread, r=froydnj.

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9f8a59996994