1646811 - Sync servo stuff.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Gate layout 2020 flex implementation behind a pref.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - Enable `order` in layout-2020.

Depends on D80231

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Cache animation computed values when animations change.

Instead of recalculating the animation style every tick of an animation,
cache the computed values when animations change. In addition to being
more efficient, this will allow us to return animation rules as property
declarations because we don't need to consult the final style to produce
them.

Depends on D80232

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Better computation of animation keyframes.

This begins to address #26625 by properly applying CSS variables during
keyframe computation and no longer using apply_declarations. Instead,
walk the declarations, combining them into IntermediateComputedKeyframe,
maintaining declarations that modify CSS custom properties. Then compute
a set of AnimationValues for each keyframe and use those to produce
interpolated animation values.

Depends on D80233

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Include animations and transitions in the cascade.

Instead of applying animations and transitions to styled elements,
include them in the cascade. This allows them to interact properly with
things like font-size and !important rules.

Depends on D80234

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Enable parsing of `flex-*` properties for layout-2020.

Depends on D80235

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: animations: Don't always re-resolve the node style.

When animations and transitions change don't always re-resolve node
style, just replace the animation and transition rules and re-cascade.

Depends on D80236

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Implement CanvasRenderingContext2D.font property.

Depends on D80237

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Enable textAlign, textBaseline and direction attributes for canvas.

Depends on D80238

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Derive Serialize and Deserialize traits for font styles.

Depends on D80239

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Implement visibility for layout_2020.

Depends on D80240

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Add DocumentAnimationSet and AnimationSetKey.

This will be used in order to hold animations for pseudo elements in the
DocumentAnimationSet. Also no longer store the OpaqueNode in the
animation and transition data structures. This is already part of the
DocumentAnimationSet key.

Depends on D80241

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Add animation and transition support for pseudo-elements.

This change extends the DocumentAnimationSet to hold animations for
pseudo-elements. Since pseudo-elements in Servo are not in the DOM like
in Gecko, they need to be handled a bit carefully in stylo. When a
pseudo-element has an animation, recascade the style. Finally, this
change passes the pseudo-element string properly to animation events.

Fixes: #10316

Depends on D80242

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Combine AnimationAndTransitionDeclarations and AnimationRules.

These two structs are very similar, so we can combine them.

Depends on D80243

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - Sync some comment changes from servo.

Depends on D80244

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - Fix servo build.

Depends on D80245

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - servo: Remove the dependency on font-kit from style.

No good reason to have this IMO, and helps remove some #[cfg] blocks.

Depends on D80246

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - Remove some unused extern crate declarations now that style is in rust 2018.

This avoids some warnings.

Depends on D80247

Comment 19

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646811 - Fix gecko build.

Depends on D80248

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7a1aeb69518
servo: Gate layout 2020 flex implementation behind a pref.
https://hg.mozilla.org/integration/autoland/rev/1743d20e0d02
Enable `order` in layout-2020.
https://hg.mozilla.org/integration/autoland/rev/400228984077
servo: Cache animation computed values when animations change.
https://hg.mozilla.org/integration/autoland/rev/f6e4935b184b
servo: Better computation of animation keyframes.
https://hg.mozilla.org/integration/autoland/rev/bdbb1eb6acf1
servo: Include animations and transitions in the cascade.
https://hg.mozilla.org/integration/autoland/rev/08aa02d53ba5
servo: Enable parsing of `flex-*` properties for layout-2020.
https://hg.mozilla.org/integration/autoland/rev/023935dbbdd6
servo: animations: Don't always re-resolve the node style.
https://hg.mozilla.org/integration/autoland/rev/366e36da6a7a
servo: Implement CanvasRenderingContext2D.font property.
https://hg.mozilla.org/integration/autoland/rev/086c24ae5689
servo: Enable textAlign, textBaseline and direction attributes for canvas.
https://hg.mozilla.org/integration/autoland/rev/82715114ac5b
servo: Derive Serialize and Deserialize traits for font styles.
https://hg.mozilla.org/integration/autoland/rev/cb3a0bb7571a
servo: Implement visibility for layout_2020.
https://hg.mozilla.org/integration/autoland/rev/04f8394b23bb
servo: Add DocumentAnimationSet and AnimationSetKey.
https://hg.mozilla.org/integration/autoland/rev/0da5430c2b2e
servo: Add animation and transition support for pseudo-elements.
https://hg.mozilla.org/integration/autoland/rev/e6d0a75ce395
servo: Combine AnimationAndTransitionDeclarations and AnimationRules.
https://hg.mozilla.org/integration/autoland/rev/61bedf23521b
Sync some comment changes from servo.
https://hg.mozilla.org/integration/autoland/rev/0023edce297c
Fix servo build.
https://hg.mozilla.org/integration/autoland/rev/0c86a4e35a8e
servo: Remove the dependency on font-kit from style.
https://hg.mozilla.org/integration/autoland/rev/a3dfa01e1721
Remove some unused extern crate declarations now that style is in rust 2018.
https://hg.mozilla.org/integration/autoland/rev/206011a5cc20
Fix gecko build.

Comment 21

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d7a1aeb69518
https://hg.mozilla.org/mozilla-central/rev/1743d20e0d02
https://hg.mozilla.org/mozilla-central/rev/400228984077
https://hg.mozilla.org/mozilla-central/rev/f6e4935b184b
https://hg.mozilla.org/mozilla-central/rev/bdbb1eb6acf1
https://hg.mozilla.org/mozilla-central/rev/08aa02d53ba5
https://hg.mozilla.org/mozilla-central/rev/023935dbbdd6
https://hg.mozilla.org/mozilla-central/rev/366e36da6a7a
https://hg.mozilla.org/mozilla-central/rev/086c24ae5689
https://hg.mozilla.org/mozilla-central/rev/82715114ac5b
https://hg.mozilla.org/mozilla-central/rev/cb3a0bb7571a
https://hg.mozilla.org/mozilla-central/rev/04f8394b23bb
https://hg.mozilla.org/mozilla-central/rev/0da5430c2b2e
https://hg.mozilla.org/mozilla-central/rev/e6d0a75ce395
https://hg.mozilla.org/mozilla-central/rev/61bedf23521b
https://hg.mozilla.org/mozilla-central/rev/0023edce297c
https://hg.mozilla.org/mozilla-central/rev/0c86a4e35a8e
https://hg.mozilla.org/mozilla-central/rev/a3dfa01e1721
https://hg.mozilla.org/mozilla-central/rev/206011a5cc20