Closed Bug 1646891 Opened 4 years ago Closed 4 years ago

browser.gesture.pinch .in and .out don't work if list all tabs button is visible

Categories

(Core :: Panning and Zooming, defect, P2)

78 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla80
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- wontfix
firefox77 --- unaffected
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- verified

People

(Reporter: imagine183hz, Assigned: kats)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Set browser.gesture.pinch.in=cmd_close and browser.gesture.pinch.out=cmd_newNavigatorTab.

Open >16-18 tabs so the down pointing button to the right of the tabs appears.
Pinch.

Actual results:

Gestures work only when that button is hidden.

Expected results:

Gestures should work with any number of tabs.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Tabbed Browser

Is your mouse pointer over the tab bar when you attempt to pinch in or out?

Flags: needinfo?(imagine183hz)

No.

Flags: needinfo?(imagine183hz)

This bug has received the "regressionwindow-wanted" tag, which means that it is necessary to find the regressor (the build modification/push that caused this issue to happen). This can be done with the mozregression (https://mozilla.github.io/mozregression/) application. A video tutorial to use it and installation instructions can be found at the provided link. It would be great if you could provide a regression yourself, but otherwise, I could try myself, after we clear out the steps to reproduce.

I am assuming that a MacBook (with a trackpad) is necessary to reproduce this issue (considering the pinch action). Is this right?
Can you correct the steps to reproduce written below?

  1. Set the following prefs:
    browser.gesture.pinch.in=cmd_close = true
    browser.gesture.pinch.out=cmd_newNavigatorTab = true
  2. Open as many tabs are needed so that the left and right arrow buttons get displayed (to navigate through so many opened tabs).
  3. Pinch. (More details here, please. do you pinch using the trackpad? where is the cursor when the pinch action is performed? what do you want to obtain by the pinching action?)
    Actual results:
    Gestures work only when that button is hidden. (left/right arrow buttons?)
    Expected results:
    Gestures should work with any number of tabs.

Thanks!

Flags: needinfo?(imagine183hz)
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
17:32.25 INFO: Narrowed integration regression window from [f6a104cc, 31a4d6df] (4 builds) to [53da1ae1, 31a4d6df] (2 builds) (~1 steps left)
17:32.25 INFO: No more integration revisions, bisection finished.
17:32.25 INFO: Last good revision: 53da1ae188f45a78d759445b2d6eaab9fe4d4919
17:32.25 INFO: First bad revision: 31a4d6dfb08fe8a764aa1868339351035f0ac69a
17:32.25 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=53da1ae188f45a78d759445b2d6eaab9fe4d4919&tochange=31a4d6dfb08fe8a764aa1868339351035f0ac69a

I'm not sure if you need a MacBook. I heard Windows has gestures too, might work there also.

Steps:

  1. I've attached a screenshot of about:config page for clarity
  2. Correct
  3. The cursor must be inside the page (where the content is, below the address and bookmark bars). The page can be an empty tab. I've been using this functionality to open and close tabs without keyboard. Pinch outward (think zooming into a picture) should open a new tab. Pinching inward (think zooming out) should close the active tab.

Also, while bisecting I noticed you must have the browser in fullscreen. This bug doesn't occur in window mode.

Flags: needinfo?(imagine183hz)
Component: Tabbed Browser → Panning and Zooming
Product: Firefox → Core
Assignee: nobody → kats
Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Regressed by: 1636473
Has Regression Range: --- → yes

The problem here is that we're not setting the mRefPoint on the gesture event dispatched from APZCCallbackHelper. Easy enough to fix, just need a bunch of plumbing.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91c8562434a9
Ensure the pinch gesture inputs dispatched to gecko have a refpoint set. r=botond
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: qe-verify+

Thanks!

Reproduced the initial issue using old Firefox 78.0. Verified that this issue is fixed now using Firefox 80.0 on macOS 10.15.6.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: