Closed Bug 1646929 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 24248 - [FragmentItem] Skip already added children in CreateBoxFragment

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24248 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24248
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[FragmentItem] Skip already added children in CreateBoxFragment

FragmentItem keeps all inline items in a flat list. When
inline box fragments are nested, |CreateBoxFragment| handles
the same item twice; once for its parent and another for its
grand parent.

This patch fixes this by skipping non-direct children.

Bug: 1096957
Change-Id: If5acba0c5bd687d156cc4530fbe6123bca9840ab

Reviewed-on: https://chromium-review.googlesource.com/2251643
WPT-Export-Revision: c8bfdc44427a872f910ac3a2d3fb54d78bf57b1c

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/406df6d65cc5
[wpt PR 24248] - [FragmentItem] Skip already added children in CreateBoxFragment, a=testonly

https://hg.mozilla.org/mozilla-central/rev/406df6d65cc5

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.