1647065 - Permafailing toolkit/components/extensions/test/xpcshell/test_extension_permissions_migration.js | xpcshell return code: 0 when Gecko 79 merges to Beta on 2020-06-29

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:

Central as Beta: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=a9acfe0eb85d3fedc68cd8f1c44eb62efa37ba66&searchStr=xpcshell&selectedTaskRun=IO3rQhe_RHmYsAjj9Ac8cA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306944616&repo=try&lineNumber=2523

[task 2020-06-20T11:44:07.666Z] 11:44:07 INFO - TEST-START | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_proxy_socks.js
[task 2020-06-20T11:44:07.667Z] 11:44:07 INFO - TEST-SKIP | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_proxy_socks.js | took 0ms
[task 2020-06-20T11:44:07.667Z] 11:44:07 INFO - Retrying tests that failed when run in parallel.
[task 2020-06-20T11:44:07.671Z] 11:44:07 INFO - xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_extension_permissions_migration.js: Per-test extra prefs will be set:
[task 2020-06-20T11:44:07.671Z] 11:44:07 INFO - services.settings.server=http://localhost:7777/remote-settings-dummy/v1
[task 2020-06-20T11:44:07.671Z] 11:44:07 INFO - services.settings.default_bucket=nonexistent-bucket-foo
[task 2020-06-20T11:44:07.674Z] 11:44:07 INFO - TEST-START | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_extension_permissions_migration.js
[task 2020-06-20T11:44:08.103Z] 11:44:08 WARNING - TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_extension_permissions_migration.js | xpcshell return code: 0
[task 2020-06-20T11:44:08.103Z] 11:44:08 INFO - TEST-INFO took 426ms
[task 2020-06-20T11:44:08.103Z] 11:44:08 INFO - >>>>>>>

Possibly regressed by Bug 1646181.
Agi, could you check this out? Thank you.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

I should have tested this, sorry 🤦‍♂️

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1647065 - Force non-legacy ExtensionPermissions tests to use rkv.

If the json bakend is enabled (e.g. in beta as of the time of writing) we will
call this in test_extension_permissions_migration.js and that's ok.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1647065 - Don't throw when calling resetVersion for json backend.

Differential Revision https://phabricator.services.mozilla.com/D80378

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1647065 - Don't throw when calling resetVersion for json backend.

If the json bakend is enabled (e.g. in beta as of the time of writing) we will
call this in test_extension_permissions_migration.js and that's ok.

Differential Revision https://phabricator.services.mozilla.com/D80378

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a3d6d3ca0b7
Force non-legacy ExtensionPermissions tests to use rkv. r=robwu

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8a3d6d3ca0b7

Comment 7

[Cosmin Sabou [:CosminS]]

fix verified in beta-sims: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&author=nbeleuzu%40mozilla.com&fromchange=80a5e10445b7fd7a3a3fe65f14623525f69a86e8&searchStr=xpc&selectedTaskRun=dQQeEhsVSkaIUZyV9hgeJQ.0