1647086 - [wpt-sync] Sync PR 24265 - Initialize text_offset for layout-generated text items

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24265 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24265
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

Initialize text_offset for layout-generated text items

|NGLogicalLineItem::text_offset| is not used for layout-
generated text items, but |NGLineTruncator| may try to
truncate it in some edge cases since r779756
\<crrev.com/c/2230583>.

This patch initializes |text_offset| for such items to
avoid accidental reads. Trying to truncate hyphens is not
correct, but this will be in future patches.

Bug: 1097042
Change-Id: Ife1f4def3568e387a17422c547e676dd2d88dac1

Reviewed-on: https://chromium-review.googlesource.com/2256100
WPT-Export-Revision: eaa705897214840e3f398f27a3582c25e3031ed1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bc458545e915a2e4e79c6258473bb863e0bf746

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e973f982585
[wpt PR 24265] - Initialize text_offset for layout-generated text items, a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0e973f982585