16472 - if fail to create shortcut, all installed files will be deleted

Status: VERIFIED INVALID

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Cathleen]

If for some reason, shortcut routine fails to create a shortcut, all the newly
installed files will get deleted, due to cleanup() call.

This doesn't sound like a correct behavior...??  or is it??  We should think
about just fail silently, and not wiping out the whole installation.

Comment 1

[Sean Su]

accepting this bug.

Dan, is there already a bug on xpinstall being able to return informative error
vs absolute? meaning return an error during complete(), but still continue?

Comment 2

[Daniel Veditz [:dveditz]]

There is some special case code for REBOOT_NEEDED -- you would have to
generalize it to "positive errors" or something. Danger to watch out for is
that in 4.x some errors that leaked out were positive, but I guess those were
bugs anyway.  There is no bug on this that I know of. Finalize() has a pretty
strictly defined set of return values, so we should add specific exceptions.

Comment 3

[Sean Su]

This is weird because the return value for creating a shortcut is always
SUCCESS.

Cathleen, can you reproduce this problem on your machine again?

Comment 4

[Sean Su]

The .xpi files do not create shortcuts, yet.  Something else must be happening
during installation time that is causing this problem.

Marking this invalid.
Cathleen will file another bug if she can reproduce it again.

Comment 5

[Jimmy Lee]

Something to keep an eye on.  Any new problems will result in new bug report.
Marking Verified!

Comment 6

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine