Closed
Bug 1647265
Opened 5 years ago
Closed 5 years ago
Make rejected-words lint case-insensitive
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox79 fixed)
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: kats, Assigned: Sylvestre)
References
Details
Attachments
(3 files, 1 obsolete file)
The rejected words lint in bug 1642825 appears to be case-sensitive. In particular there are instances of the word "Blacklist" in gfx/config/gfxConfigManager.cpp (which I'm in the process of removing, in bug 1647225) and that file isn't excluded by the lint, and yet the lint passes.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → sledru
|
Reporter | |
Comment 1•5 years ago
|
||
Also it would be nice to require that the excluded files list is sorted.
|
||
Comment 2•5 years ago
|
||
We'll want to add a new configuration to RegexType linters that control whether we use re.IGNORE_CASE or not.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D80477
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D80478
|
||
Updated•5 years ago
|
Attachment #9158215 -
Attachment is obsolete: true
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22529c87c9e8
mozlint: when type is 'regex', add the capability to ignore the case r=ahal
https://hg.mozilla.org/integration/autoland/rev/e226df37045d
mozlint/rejected-word - refresh the exclude list ignore-case: true r=Gijs
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/22529c87c9e8
https://hg.mozilla.org/mozilla-central/rev/e226df37045d
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
|
|
Reporter | |
Comment 8•5 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc1150fa0cbe
Follow-up to fix merge error with bug 1647225. r=sylvestre
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•