1647266 - notebook/logger.py 21:4 error method already defined line 14 E0102

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

python/mozperftest/mozperftest/metrics/notebook/logger.py
  21:4  error  method already defined line 14  E0102 (pylint)

Might create some unexpected behavior

To reproduce :

$  ./mach lint -l pylint -n python/mozperftest/mozperftest/metrics/notebook/logger.py

the member debug should probably be renamed

As the change should be easy, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[bsainitishkumar]

Attachment: Bug 1647266 - changed the debug variable to _debug. r: Sylvestre

Comment 2

[bsainitishkumar]

Hi, I dont know how to add a reviewer.
Should I change the commit message by making a new one?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Just click on "Edit revision" => add the person in "Reviewers"
no need to update it

Comment 4

[Carolina Caballero]

Hi. I am checking the file path "logger.py", it does not appear in the base code. :

usuario@DESKTOP-1KQGKDF /c/mozilla-source/mozilla-unified/python/mozperftest/mozperftest/metrics/notebook
$ ls
init.py notebook-sections perftestnotebook.py transformer.py utilities.py
constant.py perftestetl.py template_upload_file.html transforms

Could it be that something is missing in my configuration?. Please help me.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

yeah, doesn't exist anymore.
sorry