164733 - Multiple tabs painted redundantly on background tab load/reload

Status: VERIFIED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[sairuh (rarely reading bugmail)]

spun off from bug 159672 --this is probably a minor component to the overall
slowness i see when loading multiple pages as tabs in the background.

0. have the Quartz Debugger on, with "flash screen updates" selected. also, make
sure you have the pref turned on for loading tabs in the background.

1. open a link in a new tab --i used cmd-click.

2. watch as you get two flashes: one for the tab widget being created and
another for when the title in the tab redraws.

when i went over this with simon, he mentioned that more than one flash here
indicated redundant repainting.

Comment 1

[Mike Pinkerton (not reading bugmail)]

yup, i just saw that last week. you can see it even better in jaguar which
paints in red redundant paints.

there is something very weird with our redraw code. not sure if this is related
to our slow redraw perf (redrawing too much area), but it could be.

Comment 2

[Wincent Colaiuta]

This is probably only adding to the confusion, but I spent a bit of time running
Quartz Debugger tonight and comparing Mozilla and Chimera (nightly of
2002101804). Chimera is all over the place with redraws compared to Mozilla.

A couple of examples: guaranteed redundant paints (red flashes) whenever you
scroll in small increments (eg. by clicking on scroll arrows, or using a mouse
scroll wheel); and the throbber animation repaints the entire toolbar, not just
the throbber.

Comment 3

[Mike Pinkerton (not reading bugmail)]

i tried some stuff to prevent from drawing the full toolbar when the throbber
updates, but i can't get it to stop. i think it might be a NSToolbar bug but i
haven't coded up a testcase to prove it.

Comment 4

[Mike Pinkerton (not reading bugmail)]

offtopic, but i just verified that the throbber repainting the entire toolbar is
an apple bug. i can duplicate it in a test app that has nothing to do with chimera. 

Comment 5

[Mike Pinkerton (not reading bugmail)]

the throbber paint bug has been reported to apple as radar id #3087039

Comment 6

[Ludovic Hirlimann [:Usul]]

Mike what is the status of radar id #3087039 ?

Comment 7

[Ludovic Hirlimann [:Usul]]

still true with 2004090408 (v0.8+).

Comment 8

[Jasper]

Geoff you might want to look at this.

Comment 9

[Mike Pinkerton (not reading bugmail)]

is this still a problem?

Comment 10

[Stuart Morgan]

The bug as originally described doesn't appear to happen in the new tab implementation, but loading (or reloading) of a background tab actually causes the whole tab bar to repaint a couple of times, so there is still redundant tab painting happening.

Comment 11

[Stuart Morgan]

The main cause of what I describe in comment 10 is that either of the following triggers a redraw of the entire tab bar:
- any tab getting a new title
- any tab getting a new icon
The tab code is really convoluted, but it looks like the above could be fixed at a coarse level by replacing BrowserTabViewItem's calls to refreshTabBar: with calls to some new method to refresh just a certain tab or rect.

That won't solve all the drawing issues with the tabs, but it would substantially reduce the insanity as a quick first-pass.

Comment 12

[Stuart Morgan]

Attachment: tab-level redraw

Redraw just the tab, rather than the whole bar, when changing the favicon or title.  Still not ideal, but a heck of a lot better.

Comment 13

[Chris Lawson (gone)]

Comment on attachment 239802 [details] [diff] [review]
tab-level redraw

r=me

Comment 14

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

"That won't solve all the drawing issues with the tabs, but it would
substantially reduce the insanity as a quick first-pass."

Do we really want to close this out, or leave it open for possible future fixes?

Comment 16

[Stuart Morgan]

Future improvements could be done in later bugs.