1647354 - Start listening to workers when the TargetList is created

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

Bug 1573327 is moving the thread attaching logic from the debugger to the toolbox. This bug is focused on listening to workers from the beginning.

Comment 1

[Jason Laster [:jlast]]

Here is a few examples of things that should probably be tweaked when toggling this:

• Toolbox.onTargetAvailable should probably avoid calling startListeners["NetworkActivity"] on worker targets. (It may also be only useful on the top level target)
• This other code of Toolbox.onTargetAvailable will enable worker in the context selector. But it will be broken for the console until this bug is fixed.

Otherwise, it looks good from the WebConsole codebase.
We do ignore worker targets from WebConsoleUI and from legacy listeners.

So that it may be good to have a dedicated bug to focus on just that.

Comment 2

[Alexandre Poirot [:ochameau]]

I think you meant to block 1633727 (both at ending with 27, this is confusing :o)

Comment 3

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).

Comment 4

[Alexandre Poirot [:ochameau]]

(In reply to Jason Laster [:jlast] from comment #1)

Here is a few examples of things that should probably be tweaked when toggling this:

• Toolbox.onTargetAvailable should probably avoid calling startListeners["NetworkActivity"] on worker targets. (It may also be only useful on the top level target)

This code moved into the legacy listener for network event.

• This other code of Toolbox.onTargetAvailable will enable worker in the context selector. But it will be broken for the console until this bug is fixed.

I imagine worker have been added in the context selector via bug 1633727?
And we will fix console support in bug 1633712 or later via bug 1592584.