1647362 - fix-stacks invocation while running mach xpcshell-test breaks with python 3

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect, P1)

Description

[Geoff Brown [:gbrown]]

If I apply https://phabricator.services.mozilla.com/D78522 (run xpcshell-test in python 3) and force a crash, I hit:

TypeError: a bytes-like object is required, not 'str'

  File "/home/gbrown/src/testing/xpcshell/mach_commands.py", line 269, in run_xpcshell_test
    return xpcshell.run_test(**params)
  File "/home/gbrown/src/testing/xpcshell/mach_commands.py", line 63, in run_test
    return self.run_suite(**kwargs)
  File "/home/gbrown/src/testing/xpcshell/mach_commands.py", line 49, in run_suite
    return self._run_xpcshell_harness(**kwargs)
  File "/home/gbrown/src/testing/xpcshell/mach_commands.py", line 142, in _run_xpcshell_harness
    result = xpcshell.runTests(filtered_args)
  File "/home/gbrown/src/testing/xpcshell/runxpcshelltests.py", line 1650, in runTests
    mobileArgs, **kwargs)
  File "/home/gbrown/src/testing/xpcshell/runxpcshelltests.py", line 1851, in runTestList
    raise exceptions[0]
  File "/home/gbrown/src/testing/xpcshell/runxpcshelltests.py", line 222, in run
    self.run_test()
  File "/home/gbrown/src/testing/xpcshell/runxpcshelltests.py", line 852, in run_test
    self.log_full_output()
  File "/home/gbrown/src/testing/xpcshell/runxpcshelltests.py", line 646, in log_full_output
    self.log_line(line)
  File "/home/gbrown/src/testing/xpcshell/runxpcshelltests.py", line 627, in log_line
    line = self.fix_text_output(line).rstrip('\r\n')
  File "/home/gbrown/src/testing/xpcshell/runxpcshelltests.py", line 620, in fix_text_output
    return self.stack_fixer_function(line)
  File "/home/gbrown/src/testing/mozbase/mozrunner/mozrunner/utils.py", line 265, in stack_fixer_function
    return stack_fixer_module.fixSymbols(line, slowWarning=True, hide_errors=hideErrors)
  File "/home/gbrown/objdirs/firefox/dist/bin/fix_stacks.py", line 89, in fixSymbols
    fix_stacks.stdin.write(line)

Comment 1

[Geoff Brown [:gbrown]]

Attachment: Bug 1647362 - Improve py3 compat in fix_stacks.py; r=

Use universal_newlines as a convenient way of treating the process I/O as text,
so string read/writes continue to succeed under python 3.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e0248a432be
Improve py3 compat in fix_stacks.py; r=bc

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3e0248a432be