Closed Bug 1647366 Opened 4 years ago Closed 4 years ago

Inspect Element broken for same-origin iframes with fission + contenttoolbox.fission

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(Fission Milestone:M6c, firefox80 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 80
Project Flags:
Fission Milestone M6c
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(5 files, 1 obsolete file)

bug1647366_frame.html
131 bytes, text/html
Details
bug1647366_root.html
424 bytes, text/html
Details
Bug 1647366 - Check parent browsing context ids to find a valid BrowsingContextTarget
47 bytes, text/x-phabricator-request
Details | Review
Bug 1647366 - Re-enable context menu tests that were skipped for fission
47 bytes, text/x-phabricator-request
Details | Review
Bug 1647366 - Add a test for Inspect Element with nested remote frames
47 bytes, text/x-phabricator-request
Details | Review

Consider the following tree:

(served on domain-a.com)
<html>
  <body>
    <iframe src="domain-b.com/page1">
      #document
        body
          <iframe src="domain-b.com/page2">
            #document
              body
                <div>inspectme</div>

If fission.autostart and devtools.contenttoolbox.fission are both true, right clicking + "Inspect Element" on inspectme will not select the element in the markup view.

Attached file bug1647366_frame.html —
Attached file bug1647366_root.html (obsolete) —
Attached file bug1647366_root.html —
Attachment #9158535 - Attachment is obsolete: true

This bug can be really confusing and not so rare.
So I wish we could get to it within M2 timeframe.
It would be also important to keep DAMP test running (it has been disabled in bug 1646636)

Whiteboard: dt-fission-m2-mvp

Agreed.

It would be also important to keep DAMP test running (it has been disabled in bug 1646636)
To clarify, we only skip the inspector "custom" test with Fission in bug 1646636, the rest of the DAMP tests still runs as usual.
Still a pretty big impact because a lot of inspector DAMP tests are part of the custom test.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c).

Fission Milestone: --- → M6c
Blocks: 1651388
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7524460d2ad8 Check parent browsing context ids to find a valid BrowsingContextTarget r=ochameau,rcaliman https://hg.mozilla.org/integration/autoland/rev/8775afb03de6 Re-enable context menu tests that were skipped for fission r=ochameau,perftest-reviewers,Bebe https://hg.mozilla.org/integration/autoland/rev/8803eb351bb1 Add a test for Inspect Element with nested remote frames r=rcaliman,ochameau

https://hg.mozilla.org/mozilla-central/rev/7524460d2ad8
https://hg.mozilla.org/mozilla-central/rev/8775afb03de6
https://hg.mozilla.org/mozilla-central/rev/8803eb351bb1

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: