1647368 - Move objc video capture code to dom/media/systemservices

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Dan Minor [:dminor]]

The objc video capture code has been removed upstream. Since we're maintaining this on our own, we might as well move it to dom/media/systemservices where it is clear that it is our code and where it won't complicate future libwebrtc updates.

We have Bug 1451394 on file to switch to Chromium's newer os x camera capture code, but it is not part of libwebrtc.

Comment 1

[Dan Minor [:dminor]]

Try job: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eaf1074c80dfeccf5cf1fba37f560551e9e6aaf

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1647368 - Move objc video capture code to dom/media/systemservices; r=ng

All changes in these files are a result of code formatting being applied.
When these files were under webrtc, they were treated as third party code and
not formatting. By moving them, formatting is now applied.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1647368 - Fix include paths in moved files; r=ng

Depends on D80544

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1647368 - Update build files; r=ng

Depends on D80545

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1647368 - Update gn generated files; r=ng

Depends on D80546

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

(In reply to Dan Minor [:dminor] from comment #2)

Created attachment 9158342 [details]
Bug 1647368 - Move objc video capture code to dom/media/systemservices; r=ng

All changes in these files are a result of code formatting being applied.
When these files were under webrtc, they were treated as third party code and
not formatting. By moving them, formatting is now applied.

+1

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Dan, should we update the Firefox license information in some way for this?

Comment 8

[Dan Minor [:dminor]]

So far, I have been leaving the licensing alone when I've moved things to systemservices. But maybe we need to add a note mentioning that some of the files are originally from libwebrtc. I'll follow up with Nils when he is back.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea96803f2602
Move objc video capture code to dom/media/systemservices; r=ng
https://hg.mozilla.org/integration/autoland/rev/46a19c43afb4
Fix include paths in moved files; r=ng
https://hg.mozilla.org/integration/autoland/rev/15b1fa8da2c0
Update build files; r=ng
https://hg.mozilla.org/integration/autoland/rev/8ebb2f104016
Update gn generated files; r=ng

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ea96803f2602
https://hg.mozilla.org/mozilla-central/rev/46a19c43afb4
https://hg.mozilla.org/mozilla-central/rev/15b1fa8da2c0
https://hg.mozilla.org/mozilla-central/rev/8ebb2f104016