Closed Bug 1647368 Opened 3 months ago Closed 3 months ago

Move objc video capture code to dom/media/systemservices

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(4 files)

The objc video capture code has been removed upstream. Since we're maintaining this on our own, we might as well move it to dom/media/systemservices where it is clear that it is our code and where it won't complicate future libwebrtc updates.

We have Bug 1451394 on file to switch to Chromium's newer os x camera capture code, but it is not part of libwebrtc.

Assignee: nobody → dminor
Severity: -- → S3
Priority: -- → P3
Component: Audio/Video: Playback → WebRTC: Audio/Video

All changes in these files are a result of code formatting being applied.
When these files were under webrtc, they were treated as third party code and
not formatting. By moving them, formatting is now applied.

Depends on D80544

Depends on D80545

Depends on D80546

(In reply to Dan Minor [:dminor] from comment #2)

Created attachment 9158342 [details]
Bug 1647368 - Move objc video capture code to dom/media/systemservices; r=ng

All changes in these files are a result of code formatting being applied.
When these files were under webrtc, they were treated as third party code and
not formatting. By moving them, formatting is now applied.

+1

Dan, should we update the Firefox license information in some way for this?

Flags: needinfo?(dminor)

So far, I have been leaving the licensing alone when I've moved things to systemservices. But maybe we need to add a note mentioning that some of the files are originally from libwebrtc. I'll follow up with Nils when he is back.

Flags: needinfo?(dminor)
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea96803f2602
Move objc video capture code to dom/media/systemservices; r=ng
https://hg.mozilla.org/integration/autoland/rev/46a19c43afb4
Fix include paths in moved files; r=ng
https://hg.mozilla.org/integration/autoland/rev/15b1fa8da2c0
Update build files; r=ng
https://hg.mozilla.org/integration/autoland/rev/8ebb2f104016
Update gn generated files; r=ng
You need to log in before you can comment on or make changes to this bug.