Closed Bug 1647377 Opened 8 months ago Closed 8 months ago

Lines in Tibetan text do not wrap

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: kbrosnan, Assigned: jfkthame)

References

(
URL
)

Details

Attachments

(2 files)

Windows responsive design mode
56.18 KB, image/png
Details
Bug 1647377 - Provide basic line-breaking support for Tibetan on Android by treating TSHEG like a hyphen. r=m_kato
47 bytes, text/x-phabricator-request
Details | Review

Visit https://www.lotsawahouse.org/words-of-the-buddha/twenty-one-tara-praise in a small veiwport Firefox such as Firefox for Android or Firefox using the responsive design mode.

Expected that the lines wrap and the text fits nicely in a mobile viewport. See the "See also" section for a link to a Fenix bug showing Chrome and Firefox behavior.

Original reporter here - for me it does work properly on desktop Firefox (Linux) in responsive design mode, but fails to wrap on Android, both with Firefox Preview and with Android Firefox. Couldn't test on Windows or MacOS.

Tibetan is among the scripts treated as "complex" by intl/lwbrk/LineBreaker.cpp, which means we pass the text to a platform-specific line-breaking routine to find appropriate break points. Unfortunately, on Android we don't really have such a backend, so we fall back to a built-in implementation in intl/lwbrk/nsRuleBreaker.cpp, which only knows about Thai; it doesn't have any support for Tibetan.

Severity: -- → S3
Component: Layout: Text and Fonts → Internationalization

The real solution here will come when we move to a new line-breaking implementation based on ICU or some other segmentation API (e.g. a Rust i18n crate), but in the meantime I think we can improve the behavior trivially by just treating the intersyllabic dot (TSHEG) like a hyphen for line-breaking purposes. This will be far better than leaving Tibetan sentences entirely unbreakable.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9abb5121dcc4
Provide basic line-breaking support for Tibetan on Android by treating TSHEG like a hyphen. r=m_kato

https://hg.mozilla.org/mozilla-central/rev/9abb5121dcc4

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.