Closed Bug 1647400 Opened 3 months ago Closed 3 months ago

Permafailing ESR78 toolkit/components/search/tests/xpcshell/test_json_cache.js | xpcshell return code: 0 (from "TypeError: cacheTemplate.visibleDefaultEngines is undefined") and other search-related failures

Categories

(Firefox :: Search, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 79
Iteration:
79.2 - June 15 - June 28
Tracking Status
firefox-esr78 78+ fixed
firefox78 --- fixed
firefox79 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: standard8)

References

Details

Attachments

(1 file)

Assignee: nobody → standard8
Severity: normal → S4
Status: NEW → ASSIGNED
Iteration: --- → 79.2 - June 15 - June 28
Points: --- → 1
Priority: P5 → P1
Summary: Permafailing ESR78 toolkit/components/search/tests/xpcshell/test_json_cache.js | xpcshell return code: 0 (from "TypeError: cacheTemplate.visibleDefaultEngines is undefined") → Permafailing ESR78 toolkit/components/search/tests/xpcshell/test_json_cache.js | xpcshell return code: 0 (from "TypeError: cacheTemplate.visibleDefaultEngines is undefined") and other search-related failures

There's two issues here:

  • test_json_cache.js is broken because it didn't properly take account of legacy vs modern configuration when it was adapted.
  • test_google.js failures are due to the legacy configuration having been not correctly changed in bug 1565315
    • The newly added records for Russian based regions with the en-US locale specified "google" rather than "google-b-d".
Points: 1 → 2

I should have added: In 78, we're shipping the modern configuration by default, however this is the first time, so we should ensure the legacy configuration is correct so that if we do have to revert to it, we don't have any extra issues.

'test_json_cache.js' needs to properly take account of legacy vs modern.
'list.json' should be specifying google-b-d rather than just google.

Comment on attachment 9158340 [details]
Bug 1647400 - Fix Search Service test failures on ESR 78. r?mkaply!.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This fixes the legacy configuration to use the correct codes in Russian regions when using en-US. Although 78 is shipping the modern configuration, the legacy configuration is still present in case we need to fallback, hence we should make sure it is working correctly.

Also fixes a test failure that is a test-only issue.

  • User impact if declined:
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Covered by automated tests.
  • String or UUID changes made by this patch: None
Attachment #9158340 - Flags: approval-mozilla-esr78?
Attachment #9158340 - Flags: approval-mozilla-beta?
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e5e69b8c661
Fix Search Service test failures on ESR 78. r=mkaply.

Comment on attachment 9158340 [details]
Bug 1647400 - Fix Search Service test failures on ESR 78. r?mkaply!.

Doesn't need approval since it's test-only. Thanks for the quick fix!

Attachment #9158340 - Flags: approval-mozilla-esr78?
Attachment #9158340 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in before you can comment on or make changes to this bug.