Permafailing ESR78 toolkit/components/search/tests/xpcshell/test_json_cache.js | xpcshell return code: 0 (from "TypeError: cacheTemplate.visibleDefaultEngines is undefined") and other search-related failures
Categories
(Firefox :: Search, defect, P1)
Tracking
()
People
(Reporter: intermittent-bug-filer, Assigned: standard8)
References
Details
Attachments
(1 file)
Filed by: rvandermeulen [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=307103529&repo=mozilla-esr78
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YSwy71O2RUOy0_Ri-O_cuQ/runs/0/artifacts/public/logs/live_backing.log
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
More failures in the shippable builds:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307112850&repo=mozilla-esr78&lineNumber=6186
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307112847&repo=mozilla-esr78&lineNumber=8258
Assignee | ||
Comment 2•5 years ago
|
||
There's two issues here:
test_json_cache.js
is broken because it didn't properly take account of legacy vs modern configuration when it was adapted.test_google.js
failures are due to the legacy configuration having been not correctly changed in bug 1565315- The newly added records for Russian based regions with the en-US locale specified "google" rather than "google-b-d".
Assignee | ||
Comment 3•5 years ago
|
||
I should have added: In 78, we're shipping the modern configuration by default, however this is the first time, so we should ensure the legacy configuration is correct so that if we do have to revert to it, we don't have any extra issues.
Assignee | ||
Comment 4•5 years ago
|
||
'test_json_cache.js' needs to properly take account of legacy vs modern.
'list.json' should be specifying google-b-d rather than just google.
Assignee | ||
Comment 5•5 years ago
|
||
Comment on attachment 9158340 [details]
Bug 1647400 - Fix Search Service test failures on ESR 78. r?mkaply!.
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: This fixes the legacy configuration to use the correct codes in Russian regions when using en-US. Although 78 is shipping the modern configuration, the legacy configuration is still present in case we need to fallback, hence we should make sure it is working correctly.
Also fixes a test failure that is a test-only issue.
- User impact if declined:
- Fix Landed on Version:
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Covered by automated tests.
- String or UUID changes made by this patch: None
Comment 7•5 years ago
|
||
Comment on attachment 9158340 [details]
Bug 1647400 - Fix Search Service test failures on ESR 78. r?mkaply!.
Doesn't need approval since it's test-only. Thanks for the quick fix!
Comment 8•5 years ago
|
||
bugherder uplift |
Comment 9•5 years ago
|
||
uplift |
Comment 10•5 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Description
•