1647454 - Fix usage of GetFrameElementInternal for popup blocker in nsDocShell::DoURILoad

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Kris Maglione [:kmag]]

It can't do the right thing when the parent frame is cross-process.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

This particular callsite can probably be fixed by including the popup permission for each WindowContext on the WindowContext, and then checking the parent window context in nsDocShell.

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1647454 - Check popup permission on window context in DoURILoad.

Depends on D86808

Comment 3

[Andreas Farre [:farre]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7eaecf26104ec81ff24470a305de67bf26781f3

Comment 4

[Andreas Farre [:farre]]

Try is tentatively looking good.

Comment 5

[Neha Kochar [:neha]]

Steven, can you pick up farre's patch and try to close this one while farre is on PTO? Thanks!

Comment 6

[Steven MacLeod [:smacleod]]

Updated the patch with nika's one suggestion and tested things out on try again, still looking good - queued for landing.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bd6606d7ec8
Check popup permission on window context in DoURILoad. r=nika

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2bd6606d7ec8