1647482 - client.py: Write binary string when file is opened as binary in NSS/NSPR uplift

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kevin Jacobs [:kjacobs]]

Error with python3:

new state of security/nss/coreconf/coreconf.dep is: no blank line
toggling blank line in:  security/nss/coreconf/coreconf.dep
Traceback (most recent call last):
  File "client.py", line 194, in <module>
    update_nspr_or_nss(tag, depfile, 'security/nss', options.repo)
  File "client.py", line 135, in update_nspr_or_nss
    toggle_trailing_blank_line(depfile)
  File "client.py", line 99, in toggle_trailing_blank_line
    open(depname, "ab").write("\n")
TypeError: a bytes-like object is required, not 'str'
======= Couldn't update_nss =======

Comment 1

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1647482 - client.py: write bytes when file is opened in binary mode.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/300828aa89a3
client.py: write bytes when file is opened in binary mode. r=jcj

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/300828aa89a3