1647491 - Flickering on the https://www.apple.com/macos/big-sur-preview/ with HD 530 WebRender Win10

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

I get a bunch of flickering on the Notification Center prompt.
In about:support I see a bunch of:

RenderTextureHostOGL: Failed to open shared texture, hr=0x80070057
RenderTextureHostOGL: AcqireSync timeout, hr=0x80070057

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I don't see this in Beta

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This was probably broken by bug 1632249

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Yeah, my mozregression session confirms it.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

[Tracking Requested - why for this release]: Noticeable regression

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1632249

Comment 6

[Kelsey Gilbert [:jgilbert]]

I don't see this on Win10+AMD+WR.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Actually I think I do see it.

Comment 8

[Kelsey Gilbert [:jgilbert]]

0x80070057 is E_INVALIDARG: https://james.darpinian.com/decoder/?q=0x80070057

Comment 9

[Kelsey Gilbert [:jgilbert]]

We might be getting the race condition I was previously worried about, where the content overproduces and so drops the ref on the old-to-it surface before WR gets around to acquiring its own ref to it.

Comment 10

[Kelsey Gilbert [:jgilbert]]

Yep, it's what I thought:

[client] UseTexture 0x000000004000F5C2 => 0x0000000040010C02
[client] UseTexture 0x0000000040010C02 => 0x00000000C00113C2
[client] UseTexture 0x00000000C00113C2 => 0x00000000400073C2
Exception thrown at 0x00007FF97A0E3E49 in firefox.exe: Microsoft C++ exception: _com_error at memory location 0x000000E24BDFD8D0.
[host] OpenSharedResource(0x00000000C00113C2) failed.

Comment 11

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1647491 - Hold ref to previous webgl frontbuffer while in-flight.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a693522d3c3
Hold ref to previous webgl frontbuffer while in-flight. r=lsalzman

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6a693522d3c3

Comment 14

[Kelsey Gilbert [:jgilbert]]

Please verify!

Comment 15

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9160782 [details]
Bug 1647491 - Hold ref to previous webgl frontbuffer while in-flight.

Beta/Release Uplift Approval Request

• User impact if declined: Black flickering for some WebGL content, including the high-profile URL in in the bug.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk, as we're just holding on to resources a little longer
• String changes made/needed: none

Comment 16

[Jeff Muizelaar [:jrmuizel]]

I don't see the problem anymore.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9160782 [details]
Bug 1647491 - Hold ref to previous webgl frontbuffer while in-flight.

Approved for 79.0b3.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2baeb9bff2ee