Some videos entering fullscreen aren't calling onFullscreenChange via MediaElement.Delegate
Categories
(GeckoView :: Media, defect, P2)
Tracking
(firefox83 fixed)
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: ekager, Assigned: esawin)
Details
Attachments
(1 file)
Followup issue from fullscreen video orientation work: https://github.com/mozilla-mobile/fenix/issues/7602
It looks like some videos don't trigger the MediaElement.Delegate onFullscreenChange callback when fullscreened, so we aren't predicting an orientation for them.
Two examples:
- http://m.imomoe.in/player/7379-0-0.html
- cmdy5.com/play/24417.html?24417-1-1
Comment 1•4 years ago
|
||
This issue will probably change once bug 1623715 lands. We will revisit this use case then.
Comment 3•4 years ago
|
||
Latest update from github: https://github.com/mozilla-mobile/fenix/issues/7602#issuecomment-683190016
Assignee | ||
Comment 4•4 years ago
|
||
The MediaElement
API only dispatches onFullscreenChange
when it can identify the fullscreen media element.
Currently, this is the same behavior for the new MediaSession
API.
A. However, we could change that behavior to always dispatch onFullscreen
when there is a change in the document's fullscreen element, independent from the success of the element/metadata retrieval.
In this scenario, you would always get the minimal notification onFullscreen
, and in the best case including the ElementMetadata
.
B. Independent from the change of behavior, we could also investigate how to improve our media element identification and metadata retrieval.
Emily, would A be of any help?
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Comment 5•4 years ago
|
||
It would certainly help some cases!
For example in http://m.imomoe.in/player/7883-0-0.html we don't get a fullscreen callback, so we aren't predicting an orientation, but we are getting correct metadata.
In the case of nfmovies.com/video/?47243-1-0.html (which was mentioned in the original Fenix issue) we're not getting a fullscreen callback, but also the metadata of the active media at the point of going fullscreen is height 0, width 0, so we wouldn't be able to predict an orientation anyway.
Assignee | ||
Comment 6•4 years ago
|
||
Comment 8•4 years ago
|
||
bugherder |
Assignee | ||
Comment 9•4 years ago
|
||
Note that we haven't changed the behavior for the MediaElement
API with this, since Fenix is currently transitioning to the new MediaSession
API.
Comment 10•2 years ago
|
||
Moving some media bugs to the new GeckoView::Media component.
Description
•