Closed Bug 1647522 Opened 4 years ago Closed 4 years ago

Some videos entering fullscreen aren't calling onFullscreenChange via MediaElement.Delegate

Categories

(GeckoView :: Media, defect, P2)

79 Branch
Unspecified
All
defect

Tracking

(firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: ekager, Assigned: esawin)

Details

Attachments

(1 file)

Followup issue from fullscreen video orientation work: https://github.com/mozilla-mobile/fenix/issues/7602

It looks like some videos don't trigger the MediaElement.Delegate onFullscreenChange callback when fullscreened, so we aren't predicting an orientation for them.

Two examples:

  1. http://m.imomoe.in/player/7379-0-0.html
  2. cmdy5.com/play/24417.html?24417-1-1

This issue will probably change once bug 1623715 lands. We will revisit this use case then.

Severity: -- → S3
Priority: -- → P3

Removed priority for revisiting use case.

Priority: P3 → --

The MediaElement API only dispatches onFullscreenChange when it can identify the fullscreen media element.
Currently, this is the same behavior for the new MediaSession API.

A. However, we could change that behavior to always dispatch onFullscreen when there is a change in the document's fullscreen element, independent from the success of the element/metadata retrieval.
In this scenario, you would always get the minimal notification onFullscreen, and in the best case including the ElementMetadata.

B. Independent from the change of behavior, we could also investigate how to improve our media element identification and metadata retrieval.

Emily, would A be of any help?

Flags: needinfo?(ekager)
Assignee: nobody → esawin
Priority: -- → P2

It would certainly help some cases!

For example in http://m.imomoe.in/player/7883-0-0.html we don't get a fullscreen callback, so we aren't predicting an orientation, but we are getting correct metadata.

In the case of nfmovies.com/video/?47243-1-0.html (which was mentioned in the original Fenix issue) we're not getting a fullscreen callback, but also the metadata of the active media at the point of going fullscreen is height 0, width 0, so we wouldn't be able to predict an orientation anyway.

Flags: needinfo?(ekager)
Pushed by esawin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/964fc7d9c8e8 [1.0] Dispatch onFullscreen without metadata when there is an existing media session. r=geckoview-reviewers,agi
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Note that we haven't changed the behavior for the MediaElement API with this, since Fenix is currently transitioning to the new MediaSession API.

Moving some media bugs to the new GeckoView::Media component.

Component: General → Media
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: