Use nsIFrame::HasAnyStateBits() whenever possible instead of GetStateBits()
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: saschanaz, Assigned: saschanaz)
References
Details
Attachments
(54 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
A less verbose way.
|
Assignee | |
Updated•8 months ago
|
|
|
Assignee | |
Comment 1•8 months ago
|
||
|
||
Updated•8 months ago
|
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb356adeae14 Use HasAnyStateBits() in nsIFrame r=emilio
|
||
Comment 3•8 months ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•8 months ago
|
||
|
|
Assignee | |
Comment 5•8 months ago
|
||
Depends on D81090
|
|
Assignee | |
Comment 6•8 months ago
|
||
Depends on D81091
|
|
Assignee | |
Comment 7•8 months ago
|
||
Depends on D81092
|
|
Assignee | |
Comment 8•8 months ago
|
||
Depends on D81093
|
|
Assignee | |
Comment 9•8 months ago
|
||
Depends on D81094
|
|
Assignee | |
Comment 10•8 months ago
|
||
Depends on D81095
|
|
Assignee | |
Comment 11•8 months ago
|
||
Depends on D81096
|
|
Assignee | |
Comment 12•8 months ago
|
||
Depends on D81097
|
|
Assignee | |
Comment 13•8 months ago
|
||
Depends on D81098
|
|
Assignee | |
Comment 14•8 months ago
|
||
Depends on D81099
|
|
Assignee | |
Comment 15•8 months ago
|
||
Depends on D81100
|
|
Assignee | |
Comment 16•8 months ago
|
||
Depends on D81101
|
|
Assignee | |
Comment 17•8 months ago
|
||
Depends on D81102
|
|
Assignee | |
Comment 18•8 months ago
|
||
Depends on D81103
|
|
Assignee | |
Comment 19•8 months ago
|
||
Depends on D81104
|
|
Assignee | |
Comment 20•8 months ago
|
||
Depends on D81105
|
|
Assignee | |
Comment 21•8 months ago
|
||
Depends on D81106
|
||
Comment 22•8 months ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/990d652533e1 Use HasAnyStateBits() in nsIFrame.h r=emilio https://hg.mozilla.org/integration/autoland/rev/88eb77509d73 Use HasAnyStateBits() in nsBidiPresUtils r=emilio https://hg.mozilla.org/integration/autoland/rev/2b01d5c3f682 Use HasAnyStateBits() in nsCaret r=emilio https://hg.mozilla.org/integration/autoland/rev/71af96aab5ec Use HasAnyStateBits() in nsCSSFrameConstructor r=emilio https://hg.mozilla.org/integration/autoland/rev/4480c4f2404e Use HasAnyStateBits() in nsFrameManager r=emilio https://hg.mozilla.org/integration/autoland/rev/5ab226354730 Use HasAnyStateBits() in nsGenConList r=emilio https://hg.mozilla.org/integration/autoland/rev/a555f5f80fc4 Use HasAnyStateBits() in nsLayoutUtils r=emilio https://hg.mozilla.org/integration/autoland/rev/a45e3f362d6e Use HasAnyStateBits() in PresShell r=emilio https://hg.mozilla.org/integration/autoland/rev/4548c7dce312 Use HasAnyStateBits() in RestyleManager r=emilio https://hg.mozilla.org/integration/autoland/rev/4039b0f69fab Use HasAnyStateBits() in nsComboboxControlFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/47c86ad205f1 Use HasAnyStateBits() in nsFieldSetFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/e2e19b50d5a2 Use HasAnyStateBits() in nsListControlFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/4678ca010f6f Use HasAnyStateBits() in nsSelectsAreaFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/d0ecbcba26cd Use HasAnyStateBits() in BlockReflowInput r=emilio https://hg.mozilla.org/integration/autoland/rev/588868a1a888 Use HasAnyStateBits() in nsAbsoluteContainingBlock r=emilio https://hg.mozilla.org/integration/autoland/rev/9f7bedad0ac5 Use HasAllStateBits in nsBlockFrame.cpp r=emilio https://hg.mozilla.org/integration/autoland/rev/eda302077549 Use HasAnyStateBits() in nsBlockFrame.cpp r=emilio https://hg.mozilla.org/integration/autoland/rev/d8e375020d78 Use HasAnyStateBits() in nsBlockFrame.h r=emilio
|
|
Assignee | |
Comment 23•8 months ago
|
||
|
|
Assignee | |
Comment 24•8 months ago
|
||
Depends on D81196
|
|
Assignee | |
Comment 25•8 months ago
|
||
Depends on D81197
|
|
Assignee | |
Comment 26•8 months ago
|
||
Depends on D81198
|
|
Assignee | |
Comment 27•8 months ago
|
||
Depends on D81199
|
|
Assignee | |
Comment 28•8 months ago
|
||
Depends on D81200
|
|
Assignee | |
Comment 29•8 months ago
|
||
Depends on D81201
|
|
Assignee | |
Comment 30•8 months ago
|
||
Depends on D81202
|
|
Assignee | |
Comment 31•8 months ago
|
||
Depends on D81203
|
|
Assignee | |
Comment 32•8 months ago
|
||
Depends on D81204
|
|
Assignee | |
Comment 33•8 months ago
|
||
Depends on D81205
|
|
Assignee | |
Comment 34•8 months ago
|
||
Depends on D81206
|
|
Assignee | |
Comment 35•8 months ago
|
||
Depends on D81207
|
|
Assignee | |
Comment 36•8 months ago
|
||
Depends on D81208
|
|
Assignee | |
Comment 37•8 months ago
|
||
Depends on D81209
|
|
Assignee | |
Comment 38•8 months ago
|
||
Depends on D81210
|
|
Assignee | |
Comment 39•8 months ago
|
||
Depends on D81211
|
|
Assignee | |
Comment 40•8 months ago
|
||
Depends on D81212
|
|
Assignee | |
Comment 41•8 months ago
|
||
Depends on D81213
|
|
Assignee | |
Comment 42•8 months ago
|
||
Depends on D81214
|
|
Assignee | |
Comment 43•8 months ago
|
||
Depends on D81215
|
|
Assignee | |
Comment 44•8 months ago
|
||
Depends on D81216
|
|
Assignee | |
Comment 45•8 months ago
|
||
Depends on D81217
|
|
Assignee | |
Comment 46•8 months ago
|
||
Depends on D81218
|
|
Assignee | |
Comment 47•8 months ago
|
||
Depends on D81219
|
|
Assignee | |
Comment 48•8 months ago
|
||
Depends on D81220
|
|
Assignee | |
Comment 49•8 months ago
|
||
Depends on D81221
|
|
Assignee | |
Comment 50•8 months ago
|
||
Depends on D81222
|
|
Assignee | |
Comment 51•8 months ago
|
||
Depends on D81223
|
|
Assignee | |
Comment 52•8 months ago
|
||
Depends on D81224
|
|
Assignee | |
Comment 53•8 months ago
|
||
Depends on D81225
|
|
Assignee | |
Comment 54•8 months ago
|
||
Depends on D81226
|
|
Assignee | |
Comment 55•8 months ago
|
||
Depends on D81227
|
|
Assignee | |
Comment 56•8 months ago
|
||
Depends on D81228
|
|
Assignee | |
Comment 57•8 months ago
|
||
Depends on D81229
|
||
Comment 58•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/990d652533e1
https://hg.mozilla.org/mozilla-central/rev/88eb77509d73
https://hg.mozilla.org/mozilla-central/rev/2b01d5c3f682
https://hg.mozilla.org/mozilla-central/rev/71af96aab5ec
https://hg.mozilla.org/mozilla-central/rev/4480c4f2404e
https://hg.mozilla.org/mozilla-central/rev/5ab226354730
https://hg.mozilla.org/mozilla-central/rev/a555f5f80fc4
https://hg.mozilla.org/mozilla-central/rev/a45e3f362d6e
https://hg.mozilla.org/mozilla-central/rev/4548c7dce312
https://hg.mozilla.org/mozilla-central/rev/4039b0f69fab
https://hg.mozilla.org/mozilla-central/rev/47c86ad205f1
https://hg.mozilla.org/mozilla-central/rev/e2e19b50d5a2
https://hg.mozilla.org/mozilla-central/rev/4678ca010f6f
https://hg.mozilla.org/mozilla-central/rev/d0ecbcba26cd
https://hg.mozilla.org/mozilla-central/rev/588868a1a888
https://hg.mozilla.org/mozilla-central/rev/9f7bedad0ac5
https://hg.mozilla.org/mozilla-central/rev/eda302077549
https://hg.mozilla.org/mozilla-central/rev/d8e375020d78
|
|
Assignee | |
Updated•8 months ago
|
|
|
||
Comment 59•8 months ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e58c8fe8af74 Use HasAnyStateBits() in nsBulletFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/cf651f53934b Use HasAnyStateBits() in nsCanvasFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/af86fec8dc7f Use HasAnyStateBits() in nsColumnSetFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/b066047e4ecb Use HasAnyStateBits() in nsContainerFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/823e7b83db7e Use HasAnyStateBits() in nsFlexContainerFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/7680b2b4acbb Use HasAnyStateBits() in nsFontInflationData r=emilio https://hg.mozilla.org/integration/autoland/rev/9122fd4be5c0 Use HasAnyStateBits() in nsGfxScrollFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/a5df9604a80c Use HasAnyStateBits() in nsGridContainerFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/128dc6411039 Use HasAnyStateBits() in nsIFrameInlines r=emilio https://hg.mozilla.org/integration/autoland/rev/e13b0dba5d76 Use HasAnyStateBits() in nsInlineFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/63011088b9a1 Use HasAnyStateBits() in nsPlaceholderFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/d417b26e20d3 Use HasAnyStateBits() in nsSplittableFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/054cc085e326 Use HasAnyStateBits() in nsSubDocumentFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/5f0f3183e2ad Use HasAnyStateBits() in nsTextFrame r=emilio
|
||
Comment 60•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e58c8fe8af74
https://hg.mozilla.org/mozilla-central/rev/cf651f53934b
https://hg.mozilla.org/mozilla-central/rev/af86fec8dc7f
https://hg.mozilla.org/mozilla-central/rev/b066047e4ecb
https://hg.mozilla.org/mozilla-central/rev/823e7b83db7e
https://hg.mozilla.org/mozilla-central/rev/7680b2b4acbb
https://hg.mozilla.org/mozilla-central/rev/9122fd4be5c0
https://hg.mozilla.org/mozilla-central/rev/a5df9604a80c
https://hg.mozilla.org/mozilla-central/rev/128dc6411039
https://hg.mozilla.org/mozilla-central/rev/e13b0dba5d76
https://hg.mozilla.org/mozilla-central/rev/63011088b9a1
https://hg.mozilla.org/mozilla-central/rev/d417b26e20d3
https://hg.mozilla.org/mozilla-central/rev/054cc085e326
https://hg.mozilla.org/mozilla-central/rev/5f0f3183e2ad
|
|
||
Comment 61•8 months ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/505b89f846dd Use HasAnyStateBits() in ReflowInput r=emilio https://hg.mozilla.org/integration/autoland/rev/d8f88172efae Use HasAnyStateBits() in ViewportFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/5a0cef22c9e6 Use HasAnyStateBits() in nsMathMLContainerFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/795d7a54de9b Use HasAnyStateBits() in nsCSSRendering r=emilio https://hg.mozilla.org/integration/autoland/rev/365d0005c0e7 Use HasAnyStateBits() in nsDisplayList r=emilio https://hg.mozilla.org/integration/autoland/rev/a6a3b0266534 Use HasAnyStateBits() in nsFontFaceUtils r=emilio
|
|
||
Comment 62•8 months ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35dcb96f7780 Use HasAnyStateBits() in nsSVGContainerFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/db019d0a9525 Use HasAnyStateBits() in nsSVGForeignObjectFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/04973c870baf Use HasAnyStateBits() in nsSVGIntegrationUtils r=emilio https://hg.mozilla.org/integration/autoland/rev/9cbbdd7037b7 Use HasAnyStateBits() in nsSVGOuterSVGFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/41cc4af82ba6 Use HasAnyStateBits() in nsSVGSwitchFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/718d1c1eaec3 Use HasAnyStateBits() in nsSVGUtils r=emilio https://hg.mozilla.org/integration/autoland/rev/ee4e0dd4a71e Use HasAnyStateBits() in SVGGeometryFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/e783bb03cd57 Use HasAnyStateBits() in SVGObserverUtils r=emilio https://hg.mozilla.org/integration/autoland/rev/a77c2140e2be Use HasAnyStateBits() in SVGTextFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/3fa096f203ef Use HasAnyStateBits() in nsTableFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/d0c26e811c5f Use HasAnyStateBits() in nsBox r=emilio https://hg.mozilla.org/integration/autoland/rev/c0e437e4466f Use HasAnyStateBits() in nsBoxFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/3dbe941c525b Use HasAnyStateBits() in nsPopupSetFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/c91256f248b1 Use HasAnyStateBits() in nsSplitterFrame r=emilio https://hg.mozilla.org/integration/autoland/rev/0f0a981421ca Use HasAnyStateBits() in remaining layout files r=emilio
|
||
Comment 63•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/505b89f846dd
https://hg.mozilla.org/mozilla-central/rev/d8f88172efae
https://hg.mozilla.org/mozilla-central/rev/5a0cef22c9e6
https://hg.mozilla.org/mozilla-central/rev/795d7a54de9b
https://hg.mozilla.org/mozilla-central/rev/365d0005c0e7
https://hg.mozilla.org/mozilla-central/rev/a6a3b0266534
https://hg.mozilla.org/mozilla-central/rev/35dcb96f7780
https://hg.mozilla.org/mozilla-central/rev/db019d0a9525
https://hg.mozilla.org/mozilla-central/rev/04973c870baf
https://hg.mozilla.org/mozilla-central/rev/9cbbdd7037b7
https://hg.mozilla.org/mozilla-central/rev/41cc4af82ba6
https://hg.mozilla.org/mozilla-central/rev/718d1c1eaec3
https://hg.mozilla.org/mozilla-central/rev/ee4e0dd4a71e
https://hg.mozilla.org/mozilla-central/rev/e783bb03cd57
https://hg.mozilla.org/mozilla-central/rev/a77c2140e2be
https://hg.mozilla.org/mozilla-central/rev/3fa096f203ef
https://hg.mozilla.org/mozilla-central/rev/d0c26e811c5f
https://hg.mozilla.org/mozilla-central/rev/c0e437e4466f
https://hg.mozilla.org/mozilla-central/rev/3dbe941c525b
https://hg.mozilla.org/mozilla-central/rev/c91256f248b1
https://hg.mozilla.org/mozilla-central/rev/0f0a981421ca
Description
•