Closed Bug 1647525 Opened 8 months ago Closed 8 months ago

Use nsIFrame::HasAnyStateBits() whenever possible instead of GetStateBits()

Categories

(Core :: Layout, task)

x86_64
Windows 10
task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(54 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

A less verbose way.

Keywords: leave-open
Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb356adeae14
Use HasAnyStateBits() in nsIFrame r=emilio

Depends on D81091

Depends on D81093

Depends on D81094

Depends on D81095

Depends on D81096

Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/990d652533e1
Use HasAnyStateBits() in nsIFrame.h r=emilio
https://hg.mozilla.org/integration/autoland/rev/88eb77509d73
Use HasAnyStateBits() in nsBidiPresUtils r=emilio
https://hg.mozilla.org/integration/autoland/rev/2b01d5c3f682
Use HasAnyStateBits() in nsCaret r=emilio
https://hg.mozilla.org/integration/autoland/rev/71af96aab5ec
Use HasAnyStateBits() in nsCSSFrameConstructor r=emilio
https://hg.mozilla.org/integration/autoland/rev/4480c4f2404e
Use HasAnyStateBits() in nsFrameManager r=emilio
https://hg.mozilla.org/integration/autoland/rev/5ab226354730
Use HasAnyStateBits() in nsGenConList r=emilio
https://hg.mozilla.org/integration/autoland/rev/a555f5f80fc4
Use HasAnyStateBits() in nsLayoutUtils r=emilio
https://hg.mozilla.org/integration/autoland/rev/a45e3f362d6e
Use HasAnyStateBits() in PresShell r=emilio
https://hg.mozilla.org/integration/autoland/rev/4548c7dce312
Use HasAnyStateBits() in RestyleManager r=emilio
https://hg.mozilla.org/integration/autoland/rev/4039b0f69fab
Use HasAnyStateBits() in nsComboboxControlFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/47c86ad205f1
Use HasAnyStateBits() in nsFieldSetFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/e2e19b50d5a2
Use HasAnyStateBits() in nsListControlFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/4678ca010f6f
Use HasAnyStateBits() in nsSelectsAreaFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/d0ecbcba26cd
Use HasAnyStateBits() in BlockReflowInput r=emilio
https://hg.mozilla.org/integration/autoland/rev/588868a1a888
Use HasAnyStateBits() in nsAbsoluteContainingBlock r=emilio
https://hg.mozilla.org/integration/autoland/rev/9f7bedad0ac5
Use HasAllStateBits in nsBlockFrame.cpp r=emilio
https://hg.mozilla.org/integration/autoland/rev/eda302077549
Use HasAnyStateBits() in nsBlockFrame.cpp r=emilio
https://hg.mozilla.org/integration/autoland/rev/d8e375020d78
Use HasAnyStateBits() in nsBlockFrame.h r=emilio

Depends on D81196

Depends on D81204

Depends on D81208

Depends on D81209

Depends on D81210

Depends on D81213

Depends on D81220

Depends on D81223

Depends on D81224

Depends on D81225

Depends on D81226

Keywords: leave-open
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e58c8fe8af74
Use HasAnyStateBits() in nsBulletFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/cf651f53934b
Use HasAnyStateBits() in nsCanvasFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/af86fec8dc7f
Use HasAnyStateBits() in nsColumnSetFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/b066047e4ecb
Use HasAnyStateBits() in nsContainerFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/823e7b83db7e
Use HasAnyStateBits() in nsFlexContainerFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/7680b2b4acbb
Use HasAnyStateBits() in nsFontInflationData r=emilio
https://hg.mozilla.org/integration/autoland/rev/9122fd4be5c0
Use HasAnyStateBits() in nsGfxScrollFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/a5df9604a80c
Use HasAnyStateBits() in nsGridContainerFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/128dc6411039
Use HasAnyStateBits() in nsIFrameInlines r=emilio
https://hg.mozilla.org/integration/autoland/rev/e13b0dba5d76
Use HasAnyStateBits() in nsInlineFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/63011088b9a1
Use HasAnyStateBits() in nsPlaceholderFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/d417b26e20d3
Use HasAnyStateBits() in nsSplittableFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/054cc085e326
Use HasAnyStateBits() in nsSubDocumentFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/5f0f3183e2ad
Use HasAnyStateBits() in nsTextFrame r=emilio
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/505b89f846dd
Use HasAnyStateBits() in ReflowInput r=emilio
https://hg.mozilla.org/integration/autoland/rev/d8f88172efae
Use HasAnyStateBits() in ViewportFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/5a0cef22c9e6
Use HasAnyStateBits() in nsMathMLContainerFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/795d7a54de9b
Use HasAnyStateBits() in nsCSSRendering r=emilio
https://hg.mozilla.org/integration/autoland/rev/365d0005c0e7
Use HasAnyStateBits() in nsDisplayList r=emilio
https://hg.mozilla.org/integration/autoland/rev/a6a3b0266534
Use HasAnyStateBits() in nsFontFaceUtils r=emilio
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35dcb96f7780
Use HasAnyStateBits() in nsSVGContainerFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/db019d0a9525
Use HasAnyStateBits() in nsSVGForeignObjectFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/04973c870baf
Use HasAnyStateBits() in nsSVGIntegrationUtils r=emilio
https://hg.mozilla.org/integration/autoland/rev/9cbbdd7037b7
Use HasAnyStateBits() in nsSVGOuterSVGFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/41cc4af82ba6
Use HasAnyStateBits() in nsSVGSwitchFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/718d1c1eaec3
Use HasAnyStateBits() in nsSVGUtils r=emilio
https://hg.mozilla.org/integration/autoland/rev/ee4e0dd4a71e
Use HasAnyStateBits() in SVGGeometryFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/e783bb03cd57
Use HasAnyStateBits() in SVGObserverUtils r=emilio
https://hg.mozilla.org/integration/autoland/rev/a77c2140e2be
Use HasAnyStateBits() in SVGTextFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/3fa096f203ef
Use HasAnyStateBits() in nsTableFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/d0c26e811c5f
Use HasAnyStateBits() in nsBox r=emilio
https://hg.mozilla.org/integration/autoland/rev/c0e437e4466f
Use HasAnyStateBits() in nsBoxFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/3dbe941c525b
Use HasAnyStateBits() in nsPopupSetFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/c91256f248b1
Use HasAnyStateBits() in nsSplitterFrame r=emilio
https://hg.mozilla.org/integration/autoland/rev/0f0a981421ca
Use HasAnyStateBits() in remaining layout files r=emilio
See Also: → 1651129
You need to log in before you can comment on or make changes to this bug.