Closed Bug 1647605 Opened 3 months ago Closed 3 months ago

add remoteType to nsIParentChannel

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: freddy, Assigned: freddy)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file, 1 obsolete file)

Having a remoteType in a parent channel will help make explicit security decisions.
Nika provided the sketch of a patch. I'll fix it up and get it into the tree.

Severity: -- → N/A
Priority: -- → P2
Whiteboard: [necko-triaged]

This seems to work-ish (hey, it compiles). I'm unable to find relevant tests that I should expand. Automation is also complaining that FTP channel is completely untested. Can you help me find out where to look, Nika?

Flags: needinfo?(nika)
Attachment #9158427 - Attachment is obsolete: true

(In reply to Frederik Braun [:freddy] from comment #2)

This seems to work-ish (hey, it compiles). I'm unable to find relevant tests that I should expand. Automation is also complaining that FTP channel is completely untested. Can you help me find out where to look, Nika?

FTP is completely untested, yes. We don't have any infra for testing it right now unfortunately. It's a known issue :-) (IIRC we were going to delete support for it, but decided not to due to covid)

I'm probably not the best reviewer for this, someone from the necko team would probably be better, and might have suggestions for where to add tests.

Flags: needinfo?(nika)
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e4854c6b588
add remotetype to nsiparentchannel (and inheritors) r=kershaw
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.