1647605 - add remoteType to nsIParentChannel

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Frederik Braun [:freddy]]

Having a remoteType in a parent channel will help make explicit security decisions.
Nika provided the sketch of a patch. I'll fix it up and get it into the tree.

Comment 1

[Frederik Braun [:freddy]]

Attachment: Bug 1647605 - add remotetype to nsiparentchannel (and inheritors)

Comment 2

[Frederik Braun [:freddy]]

This seems to work-ish (hey, it compiles). I'm unable to find relevant tests that I should expand. Automation is also complaining that FTP channel is completely untested. Can you help me find out where to look, Nika?

Comment 3

[Frederik Braun [:freddy]]

Attachment: Bug 1647605 - add remotetype to nsiparentchannel (and inheritors) r?nika

Comment 4

[Frederik Braun [:freddy]]

looks green on try https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=Jg86rbf3ReWFW9l3umX-Tw.0&revision=c98e08bf7c388ae3c0418b57f739f8dc1b8bdad6

Comment 5

[Nika Layzell [:nika] (ni? for response)]

(In reply to Frederik Braun [:freddy] from comment #2)

This seems to work-ish (hey, it compiles). I'm unable to find relevant tests that I should expand. Automation is also complaining that FTP channel is completely untested. Can you help me find out where to look, Nika?

FTP is completely untested, yes. We don't have any infra for testing it right now unfortunately. It's a known issue :-) (IIRC we were going to delete support for it, but decided not to due to covid)

I'm probably not the best reviewer for this, someone from the necko team would probably be better, and might have suggestions for where to add tests.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e4854c6b588
add remotetype to nsiparentchannel (and inheritors) r=kershaw

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3e4854c6b588