1647652 - Credit card entries are not deduped if the same CC number is used with additional fields (manual fill)

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Recording of the issue

Affected version:
All - if CC specific prefs are enabled

Tested on:
Windows 10

Steps to reproduce:

1. Have a CC entry saved in storage with: CC number(362339320726338), Exp Date (08/2020)
2. Fill in a form with: CC number (362339320726338), Exp Date (04/2024), Name
3. Submit the form and chose to save the Credit Card in the Save CC doorhanger

Expected results:

1. The profiles should be merged since they have the same CC number, based on: https://mozilla.invisionapp.com/share/56E59T04Q#/screens

Actual results:

1. The CC entries are not merged.

Notes:
Scenario based on point 3 from https://bugzilla.mozilla.org/show_bug.cgi?id=1402963#c20

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1647652 - Treat a new record as a duplicate of an existing one if the cc-number matches. r?abr

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af63ff5d2d28
Treat a new record as a duplicate of an existing one if the cc-number matches. r=abr

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset af63ff5d2d28 (bug 1647652) for browser-chrome in creditCard/browser_creditCard_doorhanger.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309420975&repo=autoland&lineNumber=4290

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=U5QL1KXHRHeWlaNxZ5-R2g.0&revision=af63ff5d2d2885f5c3de4ed7c1a8a68d4f749d25

Backout:
https://hg.mozilla.org/integration/autoland/rev/576f33282a0838c87ffadd52a8271726d86f85a1

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

I had to change the logic of submission to adjust for expected values out of the test.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32c93f8ca145
Treat a new record as a duplicate of an existing one if the cc-number matches. r=abr

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset 32c93f8ca145 (bug 1647652) for Browser-chrome failure on formautofill/test/browser/creditCard/browser_creditCard_doorhanger.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309683775&repo=autoland&lineNumber=4274

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=U48PtlH0QUGqBZ49H5txVA.0&revision=32c93f8ca1454598462b32cddacedbf79d05b057

Backout:
https://hg.mozilla.org/integration/autoland/rev/02b1ba6aa361d542b189c3666ad90b764ca7aa54

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db26e6aaf139
Treat a new record as a duplicate of an existing one if the cc-number matches. r=abr

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/db26e6aaf139

Comment 9

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Nighlty 80.0a1 (2020-07-26) (64-bit) on Windows 10, MacOS 10.13 and Ubuntu 16.04.
After submitting the same CC card but with a Cardholder Name, the user is prompted to update the previous entry that thas the same CC number.