1647719 - Introduce Pref for HTTS-Only in Private Browsing Mode

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P2)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1647719: Introduce Pref for HTTS-Only in Private Browsing Mode.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: data-review-request-bug-1647719.txt

Comment 3

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9160609 [details]
data-review-request-bug-1647719.txt

I think it might have been leftover copypasta but adding a scalar to Scalars.yaml with product "firefox" is insufficient to collect this in Geckoview as requested; see https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/start/report-gecko-telemetry-in-glean.html#reporting-a-scalar.

--

# Data Review Form (to be filled by Data Stewards)

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in Scalars.yaml and the probe dictionary.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, ckerschb.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

n/a; permanent collection

9) Does the data collection use a third-party collection tool?

Negative.

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Tim Smith 👨‍🔬 [:tdsmith] from comment #3)

I think it might have been leftover copypasta but adding a scalar to
Scalars.yaml with product "firefox" is insufficient to collect this in
Geckoview as requested; see
https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/start/
report-gecko-telemetry-in-glean.html#reporting-a-scalar.

Ah, thanks. added - 'geckoview_streaming' to Scalars.yaml

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d60aa28e996e
Introduce Pref for HTTS-Only in Private Browsing Mode. r=JulianWels,jcj

Comment 6

[Chris H-C :chutten]

Hi! If you're hoping to add gecko telemetry that you hope will be collected through geckoview-embedding applications like Fenix, there are a few extra steps to go through: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/start/report-gecko-telemetry-in-glean.html

Alas, because we never got to bug 1566355 the build didn't fail when you added this. I'll add some additional links to the docs concerning geckoview_streaming to make this a little easier to find in future.

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

Thanks for the info - It's already on autoland - I'll fix that up with another patch within this bug - adding leave-open to make that happen.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d60aa28e996e

Comment 9

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1647719: Remove accidental 'geckoview_streaming' from Scalars.yaml.r=chutten

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/503494990faf
Remove accidental 'geckoview_streaming' from Scalars.yaml.r=chutten

Comment 11

[Christoph Kerschbaumer [:ckerschb]]

Once that follow up is landed we can close this bug.

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/503494990faf