Closed Bug 1647720 Opened 4 years ago Closed 4 years ago

Enable mochitest-plain with cross-origin and fission mode enabled on tier2

Categories

(Testing :: General, task, P2)

task

Tracking

(Fission Milestone:M6a, firefox80 fixed)

RESOLVED FIXED
mozilla80
Fission Milestone M6a
Tracking Status
firefox80 --- fixed

People

(Reporter: tkhan, Assigned: gbrown, Mentored)

References

Details

(Whiteboard: [7/23]: patch in review [dev-prod-2020])

Attachments

(1 file)

This request is for enabling mochitests (specifically mochitest-plain jobs) with fission and xorigin mode turned on for tier2 Linux opt and debug builds.

More information on cross-origin mode and how to enable it: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests

Tahia says the failing tests are annotated with fail-if/skip-if fission, so it should be fine to enable them now.

Tracking for Fission M6a Nightly.

Fission Milestone: --- → M6a
Severity: -- → S3
Priority: -- → P3
Blocks: 1652556

Geoff or Andrew, can you please enable mochitests with cross-origin and Fission on tier2?

Flags: needinfo?(gbrown)
Flags: needinfo?(ahal)
Assignee: nobody → gbrown
Flags: needinfo?(gbrown)
Flags: needinfo?(ahal)

Neha, would you like this configuration to replace the existing fission Linux mochitest-plain tests or run in addition to them?

Flags: needinfo?(nkochar)
Priority: P3 → P2

(In reply to Chris Peterson [:cpeterson] from comment #1)

Tahia says the failing tests are annotated with fail-if/skip-if fission, so it should be fine to enable them now.

In an initial try push, I see a lot of test failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec97fc16ca8f622267f8d9137fb6d54215726dbb

(In reply to Geoff Brown [:gbrown] from comment #4)

(In reply to Chris Peterson [:cpeterson] from comment #1)

Tahia says the failing tests are annotated with fail-if/skip-if fission, so it should be fine to enable them now.

In an initial try push, I see a lot of test failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec97fc16ca8f622267f8d9137fb6d54215726dbb

I can add additional annotations for the M-fis-xorigin test failures and hangs.

(In reply to Tahia K from comment #5)

I can add additional annotations for the M-fis-xorigin test failures and hangs.

That would be great. Thanks.

Depends on: 1653400

(In reply to Geoff Brown [:gbrown] from comment #6)

(In reply to Tahia K from comment #5)

I can add additional annotations for the M-fis-xorigin test failures and hangs.

That would be great. Thanks.

I've added annotations as part of Bug 1653400 and now the remaining failures are intermittents/known issues. Here's the latest treeherder run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c586e495af871f1daa901b1ee6f360b41e676105

Is this level of failure acceptable to proceed with?

Flags: needinfo?(gbrown)

Yes, that looks great. Thanks.

Flags: needinfo?(gbrown)

I have a patch ready to go...just waiting for an answer to the needinfo/comment 3.

(In reply to Andrew Halberstadt [:ahal] from comment #3)

Neha, would you like this configuration to replace the existing fission Linux mochitest-plain tests or run in addition to them?

Sorry for the delay, Geoff. Please go ahead and replace the current M-fis on tier1 with cross-origin M-fis on tier1.

Flags: needinfo?(nkochar)

Thanks Neha. Be aware that M-fis is currently tier 2 (except for debug with WebRender):
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=linux%2Cmochitest-plain%2Cfission

I'll keep it that way: replace the current M-fis on tier2 with cross-origin M-fis on tier2.

Status: NEW → ASSIGNED
Whiteboard: [7/23]: patch in review
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0709b3d363e9 Replace fission with fission-xorigin variant, for linux64 mochitest-plain only; r=ahal
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Regressions: 1655018
Whiteboard: [7/23]: patch in review → [7/23]: patch in review [dev-prod-2020]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: