1647800 - Pip feature Request : Auto trigger

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[yoann]

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:68.0) Gecko/68.0 Firefox/68.0

Expected results:

I couldn't find any settings to activate pip.

The ideal situation would trigger pip when a playing video leaves the viewport or

Comment 1

[fowad80865]

Please implement this feature. Not just on tab change, but if the window leaves the viewport. I would like to alt-tab to another windows and keep seeing the video.
This feature was also requested here: https://connect.mozilla.org/t5/ideas/auto-pip-when-tab-is-changed/idi-p/7917
and here: https://www.reddit.com/r/firefox/comments/wfjyf0/automatic_pictureinpicture_mode_when_window_focus/

Comment 2

[Breno Maia]

I like this idea! Yandex browser mobile\desktop have this great functionality!

Comment 3

[Ania]

Hi,
This is something we are considering for development in the future.

Comment 4

[:walker]

I've been looking for a similar option or extension for a while but was not able to find any.
Having the option to automatically open media in PiP while swapping between tabs improves the UX imo.

Comment 5

[hello]

Please implement this

Comment 6

[Daniele Ferla]

Attachment: Bug 1647800 - Picture-in-Picture: auto-toggle on tab switch. r=kpatenio,emilio,mconley

Comment 7

[exsesx]

Updated 2 hours ago, impressive 👏🏼

Thanks for not abandoning this!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Hi Daniele,

Are you still working on this? I responded with some review feedback for your patch. I'm happy to answer any questions you might have about it.

Comment 9

[Daniele Ferla]

Hi Mike,

Yes, I'm sorry for the wait. Actually I've implemented the architectural changes you proposed (primarily the usage of the "TabSelect" event), but unfortunately I got stuck on a couple of tests failing due to a bug.

Initially, I tried to move the new maybeTogglePiP function to the TabSelect handler of PictureInPicture.sys.mjs, however that handler is executed only if a PiP window has already been manually opened.

To solve that, I've chosen to use the on_TabSelect handler but in tabs.js.
The patch works as expected, but some tests are failing due to the following behaviour.

If a user has two tabs (e.g., "New tab" and "test_video.html"), with "test_video.html" currently active, with a video playing and with PiP deactivated, as soon as the user closes that tab, it blurs to the sibling tab ("New tab") and the TabSelect event is triggered thus my function is called. The JSActor async message PictureInPicture:KeyToggle is sent instantly, but it is actually received by the PictureInPictureChild.sys.mjs when the tab has been already closed, and this results in a blank PiP window.

Using a debugger I have verified that is a synchronization issue. If I introduce a delay (with a breakpoint right before my maybeTogglePiP function) to allow the PiP trigger to complete its execution also in the child actor, the PiP window appears and it's closed right before when its tab is closed, as expected.

Can I upload my current revision so I may receive some help?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

(In reply to Daniele Ferla from comment #9)

Can I upload my current revision so I may receive some help?

Absolutely!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a9833354c99
Picture-in-Picture: auto-toggle on tab switch. r=mconley,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,pip-reviewers,flod

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9a9833354c99