Closed
Bug 1647828
Opened 4 years ago
Closed 4 years ago
AXPress is available on all nodes
Categories
(Core :: Disability Access APIs, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | fixed |
| firefox77 | --- | unaffected |
| firefox78 | --- | fixed |
| firefox79 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [mac2020_1])
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-release+
|
Details | Review |
We aren't using the right selector (moxPerformPress) to filter out non-acitonable items. This makes all items pressable.
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → eitan
Status: NEW → ASSIGNED
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eee481f8258e
Block moxPerformPress selector on non-actionable nodes. r=morgan
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
|
||
Comment 4•4 years ago
|
||
Set release status flags based on info from the regressing bug 1641644
status-firefox77:
--- → unaffected
status-firefox78:
--- → affected
status-firefox-esr68:
--- → unaffected
|
|
Assignee | |
Comment 5•4 years ago
|
||
Comment on attachment 9158652 [details]
Bug 1647828 - Block moxPerformPress selector on non-actionable nodes. r?morgan
Beta/Release Uplift Approval Request
- User impact if declined: All nodes will appear to be clickable with VoiceOver
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a one line bug and a small fix.
- String changes made/needed:
Attachment #9158652 -
Flags: approval-mozilla-beta?
|
|
||
Updated•4 years ago
|
Keywords: regression
|
||
Updated•4 years ago
|
Attachment #9158652 -
Flags: approval-mozilla-beta? → approval-mozilla-release?
|
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9158652 [details]
Bug 1647828 - Block moxPerformPress selector on non-actionable nodes. r?morgan
a11y regression fix, approved for 78 rc2.
Attachment #9158652 -
Flags: approval-mozilla-release? → approval-mozilla-release+
|
|
||
Comment 7•4 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 8•4 years ago
|
||
| bugherder uplift | ||
status-firefox-esr78:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•