1647957 - Allow RDD and Socket processes to read `/proc/self/{statm,smaps}` on Linux

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Nicholas Nethercote [inactive]]

As per bug 1198552, memory reporting currently relies on reading /proc/self/statm and /proc/self/smaps on Linux. This is allowed in content processes and the GPU process, but isn't allowed in the RDD process or the Socket process.

This means that memory reporting of RDD and Socket processes is missing some important measurements, and this leads to some test failures as seen in bug 1644834.

It would be very helpful if the RDD and Socket processes could be allowed to read these files. I looked at doing this myself, and RDDSandboxPolicy and SandboxBrokerPolicyFactory::GetContentPolicy() seem relevant, but I couldn't quite work out what the changes would look like.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

You probably only need to copy/paste these two:
https://searchfox.org/mozilla-central/source/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp#543

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gcp, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[:gerard-majax]

Tests in bug 1644834 comment 14 were failing locally for me, with the patch on https://treeherder.mozilla.org/jobs?repo=try&revision=6f78b54c292ade32da9bfd729ef68b45323eb1a9 it is passing all three locally

Comment 4

[:gerard-majax]

Attachment: Bug 1647957 - Allow RDD and Socket processes to read /proc/self/{statm,smaps} on Linux r?gcp

Comment 5

[:gerard-majax]

mach try auto: https://treeherder.mozilla.org/jobs?repo=try&revision=166fc88651ed09768e10a981ef1a72379c3a7c44

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee7be8031500
Allow RDD and Socket processes to read /proc/self/{statm,smaps} on Linux r=gcp

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ee7be8031500