1647962 - Intermittent comm/calendar/test/browser/eventDialog/browser_eventDialogSize.js | undefined assertion name -

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=307316164&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Z7lhbBU9TSS0L3untSxkDw/runs/0/artifacts/public/logs/live_backing.log

---

The update to running tests on Ubuntu 18.04 has made the task dialog wider and this test is now failing.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1647962-ubuntu1804-tests-1.diff

I've fixed browser_eventDialogSize.js by increasing the values for width. Updating Ubuntu made the widgets in the task dialog wider and it began to interfere with this test.

You asked me somewhere about using Assert instead of ok or equal and here's where the difference would've been useful. When Assert is used it prints out the values being compared in the test logs, but equal doesn't (at least on TaskCluster where it matters most). This makes debugging failures easier. I've also recently discovered Assert.less, Assert.greater and others which I've used here.

I've also fixed (I think) browser_timezones.js which seems to be failing when the timezone dialog appears. I'm not sure why that is but this change seems to fix it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a248d78e1518
Fix test failures that appeared after updating test environment to Ubuntu 18.04. rs=bustage-fix

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9158805 [details] [diff] [review]
1647962-ubuntu1804-tests-1.diff

Review of attachment 9158805 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, and good catch on what was causing this.  I've noticed that timezone test failing occasionally when I run it locally (the dialog appears but the selection of a timezone from the menu fails), so I'm particularly looking forward to that one passing more reliably.  Thanks for the info about Assert.  I'm adding it to my todos to add that to the docs.

Comment 4

[Intermittent Failures Robot]

7 failures in 5252 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 7

Platform breakdown:

• linux64: 4
• linux64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1647962&startday=2020-06-22&endday=2020-06-28&tree=all