1647991 - Make wasmDis optionally return a string

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P2)

Description

[Lars T Hansen [:lth]]

We can automate some types of tests if wasmDis returns its output as a string rather than printing it to stderr. I need this for another bug.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1647991 - Allow wasmDis to return its result as a string. r?rhunt

This is useful for limited whitebox testing that inspects the assembly
output. Ask me about details (s-s).

The code, adding a thread-local, is not completely pretty. This
seemed like a better fix than adding the plumbing for a more elaborate
callback mechanism (basically we need to pass a context argument down
through the disassembly pipeline and adapt all the disassemblers),
though I'm open for discussion on this point.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/861b5e2a51e3
Allow wasmDis to return its result as a string. r=rhunt

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/861b5e2a51e3