1647995 - The SimSun font is displayed incorrectly for two minutes when the platform font list is reinitialized

Status: RESOLVED WORKSFORME

(Core :: Layout: Text and Fonts, defect)

Description

[blinky]

Attachment: testcase

Steps to reproduce:

1. Set gfx.e10s.font-list.shared to true.
2. Restart Firefox.
3. Download Font Loader.
4. Download Franklin Gothic Book Regular.ttf.
5. Open the testcase.
6. Open the Font Loader, Click on the Add Fonts button, Select the font file Franklin Gothic Book Regular.ttf then click Open.
7. Click on the Load button.

Actual results:

The SimSun font is displayed incorrectly for two minutes when the platform font list is reinitialized.

Comment 1

[Jonathan Kew [:jfkthame]]

This applies when the browser is initially launched, as well as after the list is reinitialized (due to installation/removal of fonts on the system). I thought the code was supposed to recognize when a non-ASCII font name is requested, and eagerly run the search for alternative family names, but this may be broken.

Comment 3

[Jonathan Kew [:jfkthame]]

Rather than depending on a separate search for localized font-family names, the easy way forward here is to create duplicate Family records with the localized names as part of font-list initialization. The DirectWrite API already has these names in the IDWriteLocalizedStrings that we get from each family, so we can easily record all the names (there's usually just one, except in the case of some CJK fonts).

The only downside of this is that the fonts will show up under both English and localized names in the Preferences font list. To avoid that, we can keep track of which names are for an "alternate" locale (not the current system locale) and hide those from the Preferences list, although they'll still be accepted if used in font-family.

Comment 4

[Jonathan Kew [:jfkthame]]

(Patches to fix this posted to bug 1648474, which is also related to localized font names.)

Comment 5

[blinky]

This bug has been fixed in bug 1648474.

Pushlog for fix range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9d7b71c746c0ad1077c172275b844937c7e0ec0b&tochange=df28de52416784dc5ab91de6c9baea2195878af1