1648030 - Enable packing C# releases on CI (TC)

Status: RESOLVED INCOMPLETE

(Data Platform and Tools :: Glean: SDK, task, P3)

Description

[Alessio Placitelli [:Dexter]]

After talking to Jan-Erik, looks like our best option to pack a C# release (which requires building glean-core for all the supported platforms, i.e. Windows, Linux and Mac) is to use Task Cluster.

so essentially was we need for that is a config like this: https://github.com/mozilla/glean/blob/main/taskcluster/ci/module-build/kind.yml
we probably want a dedicated docker image for that to pre-install all the tools. We use this for everything right now: https://github.com/mozilla/glean/blob/main/taskcluster/docker/linux/Dockerfile

Comment 1

[Daosheng Mu[:daoshengmu]]

Regarding to glean-core/csharp/csharp.sln x86 tests failures in local, we can just add the below code into *.csproj.

    <WinFFIDirectories Condition="'$(Platform)' == 'x86'">i686-pc-windows-msvc</WinFFIDirectories>
    <WinFFIDirectories Condition="'$(Platform)' == 'AnyCPU'">x86_64-pc-windows-msvc</WinFFIDirectories>

    ----
     
    <Content Condition="$(IsWindows) == true" Include="../../target/$(WinFFIDirectories)/$(Configuration.ToLowerInvariant())/glean_ffi.dll" CopyToOutputDirectory="Always" />

After that, if users ever build x86|x86_64 versions of glean_ffi.dll, our project will help copy them into the right folder.

Comment 2

[Alessio Placitelli [:Dexter]]

Hey :mtabara!

I tried my best to get this TC thing to run, but I'm currently stuck at what I think is a docker/TC integration problem:

[task 2020-07-06T14:29:52.700Z] + taskgraph build-image -t csharp:301dc91b84b5d3a2766d213fc7d2be168782d582dfa3daa8e40ae44f854bf4ab-pre csharp
[task 2020-07-06T14:29:52.991Z] Step 0 : FROM mcr.microsoft.com/dotnet/core/sdk:3.1-buster
[task 2020-07-06T14:29:52.991Z] Invalid repository name (core/sdk), only [a-z0-9-_.] are allowed

Do you have any clue about this?

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: GitHub Pull Request

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Found in triaging.
@:dexter - still blocked on this? I remember you managed to get passed the error but was hitting something else. Anyway I can help?

Comment 5

[Alessio Placitelli [:Dexter]]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #4)

Found in triaging.
@:dexter - still blocked on this? I remember you managed to get passed the error but was hitting something else. Anyway I can help?

Hi Mihai, we're putting this on hold for the moment, so no immediate need for action. We'll reach out again when/if operations on the C# bindings will resume.

Comment 6

[Jan-Erik Rediger [:janerik]]

(Doing bug cleanup)
The C# bindings are on hold, so we don't need releases for it.