1648038 - Create loading entries for session history in the parent even when session history is disabled

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P2)

Description

[Peter Van der Beken [:peterv]]

We have some code that decides whether session history is on, and with session history in the parent we only create entries if it is on. In some cases the code that turns on session history runs after we've started a load, and so even though we turn on session history we don't have an entry for the load. We should just always create an entry for a load, and drop it if session history is disabled.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1648038 - Don't require session history object when creating an entry. r?smaug!

Depends on D80882

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Bug 1648038 - Create session history entry in the parent without checking if session history is on for the browsing context, because we only find out later if session history is disabled. r?smaug!

Depends on D80883

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6b620d72e6b
Don't require session history object when creating an entry. r=smaug
https://hg.mozilla.org/integration/autoland/rev/78b8a2b9277a
Create session history entry in the parent without checking if session history is on for the browsing context, because we only find out later if session history is disabled. r=smaug

Comment 4

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=eQu38Np0QbOgixmhrEAIYg.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=78b8a2b9277ab347dd8f98d30dc61d842ae1b0e6

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309703721&repo=autoland&lineNumber=9671

Backout: https://hg.mozilla.org/integration/autoland/rev/07ea8c07f5ae0a350647b8c45af0f2a3e93382e8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67cd3f1beb68
Don't require session history object when creating an entry. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b5ab9546c28a
Create session history entry in the parent without checking if session history is on for the browsing context, because we only find out later if session history is disabled. r=smaug

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/67cd3f1beb68
https://hg.mozilla.org/mozilla-central/rev/b5ab9546c28a