1648054 - [wpt-sync] Sync PR 24325 - [LayoutNG] Unbreakable content may affect container size.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24325 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24325
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

[LayoutNG] Unbreakable content may affect container size.

If there's something unbreakable inside a container at a fragmentainer
boundary, and there are no possible breakpoints, it will overflow the
fragmentainer. This was already working, but in such cases, the
container should then also overflow the fragmentainer (and consume the
amount of space that it overflows).

This will also effectively make us refuse breaking inside the
block-start border or padding area (since that's included in the
intrinsic block-size, which is unbreakable).

The fieldset layout algorithm is still able to handle breaks inside
borders and padding (and had tests for it), but since this will no
longer happen, some tests had to be updated. The algorithm should also
be fixed (only a TODO for now), to no longer support such breaks (mostly
about removing a little code). There's also a fieldset-specific
regression introduced by this CL: crbug.com/1097012 . This is about
fieldset block-end padding and how the fragmentation machinery gets
confused by it. This affects two unit tests. Rather than disbling them,
I thought it was better to update with incorrect expectations (with a
TODO), since the tests are probably still useful, even with this bug.

Bug: 829028, 875235
Change-Id: I833faf7bc84328d36c9ccd640478badfd6278492
Reviewed-on: https://chromium-review.googlesource.com/2263353
WPT-Export-Revision: 751f6ee852c98e06c08cf3df50a5bfd1432c1f6d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b988deca8a98fa0edf061fceba0b2550ff11c79f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

FAIL: 3

Safari

FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3fb49263c94
[wpt PR 24325] - [LayoutNG] Unbreakable content may affect container size., a=testonly

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b3fb49263c94