1648060 - start-panel growth is not limited to available width

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Alex J Garcia]

Attachment: 0.mov

Description

If the Debugger's start-panel is dragged past the available width, the next time the end-panel is retracted, the start-panel will grow to occupy that width. Instead, the start-panel should be limited to the available width. A video of the bug is attached.

STR

1. Expand the end-panel to its maximum width.
2. Expand the start-panel past the maximum width the UI will allow, i.e., keep dragging to the right of the screen. At some point, let go. The start-panel has now been assigned a width larger than the space available to it.
3. Drag the end-panel to decrease its width. As the end-panel retracts, the start-panel will grow to occupy its assigned width.

Expected

The start-panel's possible width should be limited by the available width of the UI.

Comment 1

[Alex J Garcia]

Attachment: Bug 1648060 - start-panel sidebar prevented from being dragged wider than the available width. r=davidwalsh

I have added a helper method, calcStartPanelWidth(), to limit the start-panel on expansion.

Comment 2

[Alex J Garcia]

We discussed this during the review for Bug 1599978, here's a link to that discussion: https://phabricator.services.mozilla.com/D73381#2347415

Fix is now ready.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:loganfsmyth, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f65bc98a26f2
start-panel sidebar prevented from being dragged wider than the available width. r=davidwalsh,bomsy

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f65bc98a26f2