Remove Skype code
Categories
(Chat Core :: Skype, task)
Tracking
(thunderbird78 wontfix)
Tracking | Status | |
---|---|---|
thunderbird78 | --- | wontfix |
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file, 1 obsolete file)
61.86 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
This code never really got working and I think it is better to focus on open protocols instead of spending time reverse engineering. Ideally we would allow extensions to add protocols for the walled silos.
Assignee | ||
Comment 1•4 years ago
|
||
I'm pretty sure this hits all the places that we reference Skype.
Assignee | ||
Comment 2•4 years ago
|
||
Note that I didn't leave a stub like we have for Yahoo and Facebook Chat since this was never enabled. Frankly it was never even really usable.
Comment 3•4 years ago
|
||
Assignee | ||
Comment 4•4 years ago
|
||
(In reply to Khushil Mistry [:khushil324] from comment #3)
Comment on attachment 9159008 [details] [diff] [review]
Patch v1Review of attachment 9159008 [details] [diff] [review]:
Looks good to me. We can remove this also:
https://searchfox.org/comm-central/source/chat/locales/en-US/skype.properties
Ah! I knew I had missed something, good catch! I'll push it with that change.
Assignee | ||
Comment 5•4 years ago
|
||
Includes the additional file to remove.
Assignee | ||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9c89f01b1df1
Remove Skype code. r=khushil
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Description
•