Closed Bug 1648197 Opened 2 years ago Closed 2 years ago

Remove Skype code

Categories

(Chat Core :: Skype, task)

Tracking

(thunderbird78 wontfix)

RESOLVED FIXED
Instantbird 79
Tracking Status
thunderbird78 --- wontfix

People

(Reporter: clokep, Assigned: clokep)

Details

Attachments

(1 file, 1 obsolete file)

This code never really got working and I think it is better to focus on open protocols instead of spending time reverse engineering. Ideally we would allow extensions to add protocols for the walled silos.

Attached patch Patch v1 (obsolete) — Splinter Review

I'm pretty sure this hits all the places that we reference Skype.

Attachment #9159008 - Flags: review?(khushil324)

Note that I didn't leave a stub like we have for Yahoo and Facebook Chat since this was never enabled. Frankly it was never even really usable.

Comment on attachment 9159008 [details] [diff] [review]
Patch v1

Review of attachment 9159008 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. We can remove this also: https://searchfox.org/comm-central/source/chat/locales/en-US/skype.properties
Attachment #9159008 - Flags: review?(khushil324) → review+

(In reply to Khushil Mistry [:khushil324] from comment #3)

Comment on attachment 9159008 [details] [diff] [review]
Patch v1

Review of attachment 9159008 [details] [diff] [review]:

Looks good to me. We can remove this also:
https://searchfox.org/comm-central/source/chat/locales/en-US/skype.properties

Ah! I knew I had missed something, good catch! I'll push it with that change.

Attached patch Patch v2Splinter Review

Includes the additional file to remove.

Attachment #9159008 - Attachment is obsolete: true
Attachment #9159475 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 79
You need to log in before you can comment on or make changes to this bug.