1648197 - Remove Skype code

Status: RESOLVED FIXED

(Chat Core :: Skype, task)

Description

[Patrick Cloke [:clokep]]

This code never really got working and I think it is better to focus on open protocols instead of spending time reverse engineering. Ideally we would allow extensions to add protocols for the walled silos.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch v1

I'm pretty sure this hits all the places that we reference Skype.

Comment 2

[Patrick Cloke [:clokep]]

Note that I didn't leave a stub like we have for Yahoo and Facebook Chat since this was never enabled. Frankly it was never even really usable.

Comment 3

[Khushil Mistry [:khushil324]]

Comment on attachment 9159008 [details] [diff] [review]
Patch v1

Review of attachment 9159008 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. We can remove this also: https://searchfox.org/comm-central/source/chat/locales/en-US/skype.properties

Comment 4

[Patrick Cloke [:clokep]]

(In reply to Khushil Mistry [:khushil324] from comment #3)

Comment on attachment 9159008 [details] [diff] [review]
Patch v1

Review of attachment 9159008 [details] [diff] [review]:

Looks good to me. We can remove this also:
https://searchfox.org/comm-central/source/chat/locales/en-US/skype.properties

Ah! I knew I had missed something, good catch! I'll push it with that change.

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Patch v2

Includes the additional file to remove.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9c89f01b1df1
Remove Skype code. r=khushil