Closed Bug 1648277 Opened 4 years ago Closed 4 years ago

MediaElementAudioSourceNode should take into account preservesPitch

Categories

(Core :: Audio/Video: Playback, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1517199

People

(Reporter: tguilbert, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; CrOS x86_64 13020.67.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Safari/537.36

Steps to reproduce:

  • Create an audio element, and a WebAudio MediaElementAudioSourceNode from it.
  • Set preservesPitch (or mozPreservesPitch) to false, and playback rate to 2.0
  • Play the audio element

Example test page:
https://tguilbert-google.github.io/preserves_pitch/pitch_detect.html

Actual results:

Pitch is preserved.

Expected results:

Pitch should be shifted.

While there is no formal spec for preservesPitch that describes this behavior, it would make sense to allow for pitch shifting for WebAudio.

I cannot test how this behaves on Safari due to https://bugs.webkit.org/show_bug.cgi?id=211394.

Chrome's behavior is (will be) to allow pitch shifting when preservesPitch=false.

The reason to do this is that it's impossible for WebAudio to get pitch preserved input from the media element otherwise.

Setting the component in order to involve the development team to review this.
Thanks for reporting!

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core
Version: other → unspecified

Hi, Paul,
Is this issue related with bug1517199? I think the reason of the pitch not being changed is because we didn't apply the playback rate change on MediaElementAudioSourceNode?
Thank you.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(padenot)
Resolution: --- → FIXED

Sorry, I didn't mean to close this bug.

Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: FIXED → ---
Severity: -- → S3

Yes, this is a dupe of bug 1517199, that covers both preservesPitch and playbackRate.

Dale, Thomas, thanks for filing.

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Flags: needinfo?(padenot)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.