1648280 - [wpt-sync] Sync PR 24329 - [css-pseudo] Fix DCHECK failure with ::marker and text-combine-upright

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24329 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24329
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-pseudo] Fix DCHECK failure with ::marker and text-combine-upright

The 'text-combine-upright' property is not supported in LayoutNG, so it
forces the element to use legacy layout. However, when used on ::marker,
this could leave the list item using LayoutNG and only force the marker
to legacy. But markers depend on their originating list item, so this
would make some DCHECKs fail.

This patch makes DefinitelyNewFormattingContext always return false for
::marker, even if it's an outside marker with 'display: inline-block'.
This way ForceLegacyLayoutInFormattingContext will also force the list
item to use legacy layout when the marker requires it.

Bug: 457718

TEST=external/wpt/css/css-pseudo/marker-text-combine-upright.html

The test fails because 'text-combine-upright' doesn't seem to work well
on pseudo-elements, but now it doesn't crash.

Change-Id: I7f9f26914af39a9d30dbcff7fcd1ae1308981989
Reviewed-on: https://chromium-review.googlesource.com/2264129
WPT-Export-Revision: 73e93174d2c96c69f69f620add95cdbddf6a9f83

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ce966b64238a9dfefba39ff8ae84b5f85786529

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/marker-text-combine-upright.html: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67c3c3dfbd60
[wpt PR 24329] - [css-pseudo] Fix DCHECK failure with ::marker and text-combine-upright, a=testonly
https://hg.mozilla.org/integration/autoland/rev/055a516ad870
[wpt PR 24329] - Update wpt metadata, a=testonly

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/67c3c3dfbd60
https://hg.mozilla.org/mozilla-central/rev/055a516ad870