1648281 - Remove newFailed and reconciled from incoming counts in sync ping

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

We've almost never been able to collect newFailed on any engines except desktop (it's very idiosyncratic for desktop). Reconciled is also tricky to thread through for rust engines on desktop, but most importantly, this is data collected in the sync ping that we not only have no current use for, we have no plans of the use, nor ideas for how we would use them.

So lets just take them out.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

https://searchfox.org/mozilla-central/search?q=newFailed (and similarly for reconciled) has some hits which are for telemetry and some which is just for logging. We want to remove everything telemetry related.

Comment 2

[Sammy Khamis [:skhamis]]

Attachment: Bug 1648281 - Removed incoming telemetry for newFailed and reconciled for sync ping r?markh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b13ba4a4939
Removed incoming telemetry for newFailed and reconciled for sync ping r=markh

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 5b13ba4a4939 (Bug 1648281) for causing xpcshell failures in test_syncengine_sync.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/5e4330b48f4a97164e9a132db97a9627d78fcef6
Push with failures, failure log.

Comment 5

[Sammy Khamis [:skhamis]]

Fixed the issue. Below is the trybuild with that test passing:
https://treeherder.mozilla.org/jobs?repo=try&revision=b360ef8b2c2fab55e06a83680d1d5b344eb21ece

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55e5713da50a
Removed incoming telemetry for newFailed and reconciled for sync ping r=markh

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/55e5713da50a