1648286 - Exclude tools/lint/eslint/eslint-plugin-mozilla/node_modules/ (and/or other node_modules?) directories from rejected words list

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[:Gijs (he/him)]

Although we can obviously file tickets against upstream repos that we require in node code, we shouldn't try to lint them...

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Andrew Halberstadt [:ahal]]

I might be mistaken, but I think that's the old location for the node_modules dir and now all the node stuff uses a single root node_modules directory. The root node_modules is already globally excluded from all linters here:
https://searchfox.org/mozilla-central/source/tools/lint/mach_commands.py#34

Mark, do I have it right? If so you can delete that directory and we can resolve this.

Comment 3

[:Gijs (he/him)]

It may have been created when I had to run the tests for adding a new linter rule?

Comment 4

[Mark Banner (:standard8)]

(In reply to Andrew Halberstadt [:ahal] from comment #2)

I might be mistaken, but I think that's the old location for the node_modules dir and now all the node stuff uses a single root node_modules directory. The root node_modules is already globally excluded from all linters here:
https://searchfox.org/mozilla-central/source/tools/lint/mach_commands.py#34

Mark, do I have it right? If so you can delete that directory and we can resolve this.

Not this time. When we run the eslint-plugin-mozilla tests, we create the node_modules directory. I believe various other places like browser/components/newtab and one of the devtools directories can also create their own node_modules directories.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1648286 - When linting, ignore all node_modules directories across the tree not only the top-level ones. r?ahal

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/486b74886dbe
When linting, ignore all node_modules directories across the tree not only the top-level ones. r=ahal

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/486b74886dbe