Closed
Bug 1648391
Opened 5 years ago
Closed 5 years ago
nsTSubstringTuple<T>::IsDependentOnWithLength is suboptimal
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
Details
Attachments
(2 files)
nsTSubstringTuple<T>::IsDependentOnWithLength unnecessarily evaluates dependency for all nodes, but can stop to do so once one branch is dependent.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D81054
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b204ac2decb6
Use logical or rather than binary or to allow for short-circuit evaluation. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/fdd9ea55b4ad
Use rhs-first optimization from IsDependentOn in IsDependentOnWithLength. r=froydnj
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b204ac2decb6
https://hg.mozilla.org/mozilla-central/rev/fdd9ea55b4ad
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
|
||
Updated•5 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•