1648430 - string_ipc Rust test failing in ccov builds

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Marco Castelluccio [:marco]]

[task 2020-06-25T04:40:42.136Z] 04:40:42     INFO -  check> test string_ipc ... FAILED
[task 2020-06-25T04:40:42.136Z] 04:40:42     INFO -  check>
[task 2020-06-25T04:40:42.136Z] 04:40:42     INFO -  check> failures:
[task 2020-06-25T04:40:42.136Z] 04:40:42     INFO -  check>
[task 2020-06-25T04:40:42.136Z] 04:40:42     INFO -  check> ---- string_ipc stdout ----
[task 2020-06-25T04:40:42.136Z] 04:40:42     INFO -  check> ---- string_ipc stderr ----
[task 2020-06-25T04:40:42.137Z] 04:40:42     INFO -  check> thread 'main' panicked at 'Cannot get test value for Child(StringMetricIpc(MetricId { category: "ipc", name: "string metric" })) in non-parent process!', toolkit/components/glean/api/src/metrics/string.rs:98:40
[task 2020-06-25T04:40:42.137Z] 04:40:42     INFO -  check> stack backtrace:
[task 2020-06-25T04:40:42.137Z] 04:40:42     INFO -  check>    0:     0x55d0b82a37c4 - backtrace::backtrace::libunwind::trace::h5ae3454ebe40b621
[task 2020-06-25T04:40:42.137Z] 04:40:42     INFO -  check>                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.44/src/backtrace/libunwind.rs:86
[task 2020-06-25T04:40:42.137Z] 04:40:42     INFO -  check>    1:     0x55d0b82a37c4 - backtrace::backtrace::trace_unsynchronized::hbf6f267a483fb2c0
[task 2020-06-25T04:40:42.137Z] 04:40:42     INFO -  check>                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.44/src/backtrace/mod.rs:66
[task 2020-06-25T04:40:42.138Z] 04:40:42     INFO -  check>    2:     0x55d0b82a37c4 - std::sys_common::backtrace::_print_fmt::h37755015d94b9085
[task 2020-06-25T04:40:42.138Z] 04:40:42     INFO -  check>                                at src/libstd/sys_common/backtrace.rs:78
[task 2020-06-25T04:40:42.138Z] 04:40:42     INFO -  check>    3:     0x55d0b82a37c4 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h0561c8cd3569b40d
[task 2020-06-25T04:40:42.138Z] 04:40:42     INFO -  check>                                at src/libstd/sys_common/backtrace.rs:59
[task 2020-06-25T04:40:42.138Z] 04:40:42     INFO -  check>    4:     0x55d0b82db1dc - core::fmt::write::h86a597a35d48a212
[task 2020-06-25T04:40:42.138Z] 04:40:42     INFO -  check>                                at src/libcore/fmt/mod.rs:1063
[task 2020-06-25T04:40:42.138Z] 04:40:42     INFO -  check>    5:     0x55d0b82954e3 - std::io::Write::write_fmt::h73d9dc0f29eefe48
[task 2020-06-25T04:40:42.139Z] 04:40:42     INFO -  check>                                at src/libstd/io/mod.rs:1426
[task 2020-06-25T04:40:42.139Z] 04:40:42     INFO -  check>    6:     0x55d0b82a85f5 - std::sys_common::backtrace::_print::h6c60c5ee09af0233
[task 2020-06-25T04:40:42.139Z] 04:40:42     INFO -  check>                                at src/libstd/sys_common/backtrace.rs:62
[task 2020-06-25T04:40:42.139Z] 04:40:42     INFO -  check>    7:     0x55d0b82a85f5 - std::sys_common::backtrace::print::hf9d1db01634f9b2a
[task 2020-06-25T04:40:42.139Z] 04:40:42     INFO -  check>                                at src/libstd/sys_common/backtrace.rs:49
[task 2020-06-25T04:40:42.139Z] 04:40:42     INFO -  check>    8:     0x55d0b82a85f5 - std::panicking::default_hook::{{closure}}::h1db9298dd213ae95
[task 2020-06-25T04:40:42.140Z] 04:40:42     INFO -  check>                                at src/libstd/panicking.rs:204
[task 2020-06-25T04:40:42.140Z] 04:40:42     INFO -  check>    9:     0x55d0b82a8342 - std::panicking::default_hook::h3272faf6cc91fd2e
[task 2020-06-25T04:40:42.140Z] 04:40:42     INFO -  check>                                at src/libstd/panicking.rs:224
[task 2020-06-25T04:40:42.140Z] 04:40:42     INFO -  check>   10:     0x55d0b7cc98dd - <alloc::boxed::Box<F> as core::ops::function::Fn<A>>::call::ha9b201981a2b4784
[task 2020-06-25T04:40:42.140Z] 04:40:42     INFO -  check>                                at /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/liballoc/boxed.rs:1031
[task 2020-06-25T04:40:42.140Z] 04:40:42     INFO -  check>   11:     0x55d0b7cc98dd - test::run_test_in_spawned_subprocess::{{closure}}::hd9f7905eb26bd942
[task 2020-06-25T04:40:42.141Z] 04:40:42     INFO -  check>                                at src/libtest/lib.rs:631
[task 2020-06-25T04:40:42.141Z] 04:40:42     INFO -  check>   12:     0x55d0b7cc992d - test::run_test_in_spawned_subprocess::{{closure}}::h8048138626896447
[task 2020-06-25T04:40:42.141Z] 04:40:42     INFO -  check>                                at src/libtest/lib.rs:641
[task 2020-06-25T04:40:42.141Z] 04:40:42     INFO -  check>   13:     0x55d0b82a8d25 - std::panicking::rust_panic_with_hook::hb976084785e50594
[task 2020-06-25T04:40:42.141Z] 04:40:42     INFO -  check>                                at src/libstd/panicking.rs:474
[task 2020-06-25T04:40:42.141Z] 04:40:42     INFO -  check>   14:     0x55d0b82a883b - rust_begin_unwind
[task 2020-06-25T04:40:42.141Z] 04:40:42     INFO -  check>                                at src/libstd/panicking.rs:378
[task 2020-06-25T04:40:42.142Z] 04:40:42     INFO -  check>   15:     0x55d0b82a87ab - std::panicking::begin_panic_fmt::h82e7fee729e9f5fb
[task 2020-06-25T04:40:42.142Z] 04:40:42     INFO -  check>                                at src/libstd/panicking.rs:332
[task 2020-06-25T04:40:42.142Z] 04:40:42     INFO -  check>   16:     0x55d0b7d0a268 - glean::metrics::string::StringMetric::test_get_value::hacc5e9e1fbb77cf3
[task 2020-06-25T04:40:42.142Z] 04:40:42     INFO -  check>                                at toolkit/components/glean/api/src/metrics/string.rs:98
[task 2020-06-25T04:40:42.142Z] 04:40:42     INFO -  check>   17:     0x55d0b7c8162d - string::string_ipc::{{closure}}::h8d29eff615155094
[task 2020-06-25T04:40:42.142Z] 04:40:42     INFO -  check>                                at toolkit/components/glean/api/tests/string.rs:57
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check>   18:     0x55d0b7c75638 - std::panicking::try::do_call::hfd18eeff09ef5096
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check>                                at /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libstd/panicking.rs:303
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check>   19:     0x55d0b82b9d49 - __rust_maybe_catch_panic
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check>                                at src/libpanic_abort/lib.rs:30
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check>
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check>
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check> failures:
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check>     string_ipc
[task 2020-06-25T04:40:42.143Z] 04:40:42     INFO -  check>
[task 2020-06-25T04:40:42.144Z] 04:40:42     INFO -  check> test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1635255

Comment 2

[Calixte Denizet (:calixte)]

It's likely because of:
https://hg.mozilla.org/mozilla-central/file/122fa4a0e054fca31fe8f6b35b88a865323c9290/toolkit/components/glean/api/tests/string.rs#l56
and:
https://searchfox.org/mozilla-central/source/browser/config/mozconfigs/linux64/code-coverage#16 (-Zpanic_abort_tests)

Comment 3

[Chris H-C :chutten]

Oh no! I can't test panics? Will I have to skip this test?

Comment 4

[Chris H-C :chutten]

Or, :marco, can we switch to non-aborting panics in ccov?

Comment 5

[Calixte Denizet (:calixte)]

Afaik, we can't know that we're in a ccov build from rust.
So we need to export MOZ_CODE_COVERAGE in environment and then you could check for it before running panic stuff.

Comment 6

[Calixte Denizet (:calixte)]

I'll disable the glean tests for ccov builds.

Comment 7

[Calixte Denizet (:calixte)]

Attachment: Bug 1648430 - Don't run glean tests to fix ccov builds

For ccov builds, rust tests are ran with -Cpanic=abort -Zpanic_abort_tests
and some glean tests are testing panics so in order to have ccov builds we must disable them.

Comment 8

[Calixte Denizet (:calixte)]

An try is green:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=asRIqNbARre3ho9gYKGAJg.0&revision=542d8689d675a839a45b48f6ffc57ecf61ac2e2b

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6727729203e9
Don't run glean tests to fix ccov builds r=firefox-build-system-reviewers,rstewart

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6727729203e9

Comment 11

[Intermittent Failures Robot]

3 failures in 5252 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3

Platform breakdown:

• linux64-ccov: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1648430&startday=2020-06-22&endday=2020-06-28&tree=all

Comment 12

[Marco Castelluccio [:marco]]

Could you file a follow-up to run Glean tests but only avoid running the ones that expect panics?

Comment 13

[Calixte Denizet (:calixte)]

I filed a bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1753615