1648490 - Profile Manager cannot remove the profile that contains a directory with a trailing dot

Status: NEW

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Tom Tung [:tt, :ttung]]

1. Visit the site with a trailing dot and using DOM Storage.
2. Remove the profile in about:profiles

Actual:
There is no warning or error shows up but the profile is not removed

Expect:
The profile should be removed

The fix should probably be done by using the prefix \\?\ or using QMS's API for https://searchfox.org/mozilla-central/source/toolkit/profile/nsIToolkitProfile.idl#85

Comment 1

[Tom Tung [:tt, :ttung]]

We also need to check if other operation in ProfileManager would be affected as well.

Comment 2

[Tom Tung [:tt, :ttung]]

It's in https://searchfox.org/mozilla-central/source/toolkit/profile/nsToolkitProfileService.cpp#88-130

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1648490 - Remove the storage directory first before removing the profile directory;

Comment 4

[Tom Tung [:tt, :ttung]]

I will need to check other APIs that access the profiles and check if we can have a test.

Comment 5

[Tom Tung [:tt, :ttung]]

I'm not sure if I can easily write a test for that.

Also, there is another file access to profile dir: https://searchfox.org/mozilla-central/source/toolkit/xre/ProfileReset.h#54

That makes me consider using \\?\ for ProfileManager.
However, I want to avoid deploying \\?\ prefix to other modules at the moment if possible. We should only do that when we have more confidence (given that we only ship the prefix to the release users for a month and there are bugs related to \\?\).

Comment 6

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1648490 - Copy the storage directory first before copying the other files/directories in the profile directory;

Depends on D81302

Comment 7

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a8d682e24697260fe5ed37a5d4dc73c8d4997ca&selectedTaskRun=Z3MF9_qRR4SsauwGUf15fg.0

Comment 8

[Tom Tung [:tt, :ttung]]

try for the first patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f7522610f188ecffe00c237d3633b3dcfe726ec
If it looks good, I will push that patch into m-c.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mossop, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.