1648511 - the channel should be resumed even the applyChange throws

Status: RESOLVED INVALID

(WebExtensions :: Request Handling, defect)

Description

[Junior [inactive]]

This is followup of bug 1648101.

the suspension should be resumed even the channel fails to set new listener
https://searchfox.org/mozilla-central/rev/cfaa250d14e344834932de4c2eed0061701654da/toolkit/components/extensions/webrequest/WebRequest.jsm#935

Comment 1

[Rob Wu [:robwu]]

The channel is already resumed outside the large try-catch block (containing the .suspend() call): https://searchfox.org/mozilla-central/rev/cfaa250d14e344834932de4c2eed0061701654da/toolkit/components/extensions/webrequest/WebRequest.jsm#1064

What is missing?

Comment 2

[Shane Caraveo (:mixedpuppy)]

We also protect against multiple suspend calls on a channel.

https://searchfox.org/mozilla-central/rev/cfaa250d14e344834932de4c2eed0061701654da/toolkit/components/extensions/webrequest/ChannelWrapper.cpp#248

Comment 3

[Junior [inactive]]

Thanks for taking a look, Rob and Shane.
It might be somewhere else given we see two suspension but one resumption.
I'll take another look to see where the suspension is.

Comment 4

[Junior [inactive]]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1648101#c12
I believe it's not about the SetNewListener failure.

INVALID given I failed to find a way to reproduce and figure out where the suspension is. (Even it's right after SetNewListener, but it still possible suspended by other on-modify observers for the log https://bugzilla.mozilla.org/show_bug.cgi?id=1648101#c3)