1648755 - Really gate thread ops on the pref

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P2)

Description

[Lars T Hansen [:lth]]

At the moment, thread operations are gated on the module using shared memory, and the module gets to use shared memory only if the pref is enabled. With bug 1619196 the former gate disappears (and it was anyway ineffective for atomic.fence, which does not require shared memory). We therefore want to gate the thread operations in the validator and both compilers on the pref itself. The easiest way to do this is to just insert the obvious pref check in the decoding switches, as we do for other non-shipped instruction set extensions.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1648755 - gate availability of thread ops on the shared memory pref. r=rhunt

We will shortly be unable to depend on the presence of shared memory
as a gate for the thread operations, so just add proper gating
depending on the shared-memory pref.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb95d039d9a0
gate availability of thread ops on the shared memory pref. r=rhunt

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/eb95d039d9a0