Closed Bug 1648755 Opened 4 months ago Closed 4 months ago

Really gate thread ops on the pref

Categories

(Core :: Javascript: WebAssembly, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file)

At the moment, thread operations are gated on the module using shared memory, and the module gets to use shared memory only if the pref is enabled. With bug 1619196 the former gate disappears (and it was anyway ineffective for atomic.fence, which does not require shared memory). We therefore want to gate the thread operations in the validator and both compilers on the pref itself. The easiest way to do this is to just insert the obvious pref check in the decoding switches, as we do for other non-shipped instruction set extensions.

We will shortly be unable to depend on the presence of shared memory
as a gate for the thread operations, so just add proper gating
depending on the shared-memory pref.

Attachment #9159689 - Attachment description: Bug 1648755 - gate availability of thread ops on the shared memory pref. r?rhunt → Bug 1648755 - gate availability of thread ops on the shared memory pref. r=rhunt
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb95d039d9a0
gate availability of thread ops on the shared memory pref. r=rhunt
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.