Closed
Bug 1648798
Opened 4 years ago
Closed 4 years ago
Account for external checks in import_mozilla_checks.py
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement, P1)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox80 fixed)
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: jewilde, Assigned: jewilde)
References
Details
Attachments
(1 file)
Right now importing the moz checks into llvm to build clang-tidy will break if external checks exist in tree due to 'external/' not being prepended to filenames in CMakeLists in the same way that 'alpha/' is prepended to filenames for alpha checks.
We should add the same mechanism we have in place for importing alpha checks for external checks. I'll take care of the changes needed here since I was asked to do it with regards to the check I'm currently working on.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9160363 -
Attachment description: Bug 1648798 - Add option for importing external checks into clang-tidy; → Bug 1648798 - Add option for importing external checks into clang-tidy; r=andi
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0970fcc8e0d9 Add option for importing external checks into clang-tidy; r=tjr,andi
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•