1648810 - popups fail to appear after bug 1569103 is applied

Status: RESOLVED WORKSFORME

(Web Compatibility :: Site Reports, defect)

Description

[Ronald Tilby]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

login to familysearch.org
in the upper right area of the page click the message icon or the bell icon
a popup should appear showing messages or notifications.

Mozregression log:
2020-06-26T10:30:08.041000: INFO : application_version: 78.0a1
2020-06-26T10:30:08.041000: INFO : platform_buildid: 20200505181023
2020-06-26T10:30:08.041000: INFO : platform_changeset: eac04828a52aeff35fddafd13d80672df06db334
2020-06-26T10:30:08.041000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2020-06-26T10:30:08.041000: INFO : platform_version: 78.0a1
2020-06-26T10:31:43.642000: INFO : b''
2020-06-26T10:31:43.642000: INFO : b'###!!! [Child][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost'
2020-06-26T10:31:43.642000: INFO : b''
2020-06-26T10:31:43.670000: INFO : b''
2020-06-26T10:31:43.670000: INFO : b'###!!! [Child][MessageChannel::SendAndWait] Error: Channel error: cannot send/recv'
2020-06-26T10:31:43.670000: INFO : b''
2020-06-26T10:31:48.268000: INFO : Narrowed integration regression window from [4d31941a, e0f2683f] (3 builds) to [eac04828, e0f2683f] (2 builds) (~1 steps left)
2020-06-26T10:31:48.280000: DEBUG : Starting merge handling...
2020-06-26T10:31:48.280000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=e0f2683f03168b7de89dc9f15ee7c07db3004f65&full=1
2020-06-26T10:31:48.280000: DEBUG : redo: attempt 1/3
2020-06-26T10:31:48.280000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=e0f2683f03168b7de89dc9f15ee7c07db3004f65&full=1',), kwargs: {}, attempt #1
2020-06-26T10:31:48.280000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2020-06-26T10:31:48.830000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=e0f2683f03168b7de89dc9f15ee7c07db3004f65&full=1 HTTP/1.1" 200 None
2020-06-26T10:31:48.880000: DEBUG : Found commit message:
Bug 1569103: Add support for "dayPeriod" option to Intl.DateTimeFormat. r=jwalden

Nightly-only for now until the open spec issues are addressed.

Differential Revision: https://phabricator.services.mozilla.com/D39465

2020-06-26T10:31:48.880000: DEBUG : Did not find a branch, checking all integration branches
2020-06-26T10:31:48.885000: INFO : The bisection is done.
2020-06-26T10:31:48.885000: INFO : Stopped

Actual results:

After bug https://bugzilla.mozilla.org/show_bug.cgi?id=1569103 was applied to nightly nothing happens in response to clicking the message or bell icons.

Expected results:

Before bug https://bugzilla.mozilla.org/show_bug.cgi?id=1569103 was applied to nightly the appropriate popup appears.

Comment 1

[Augusto Pace]

Hi,

I was NOT able to reproduce this issue on Windows 10 with Firefox version Release 78.0 (64-bit) - Beta 79.0b1 (64-bit). Marking those flags as unaffected.
But I was able to reproduce the issue on version Nightly 80.0a1 (2020-06-30) (64-bit). Marking that flag as affected.

Also I'm setting status to NEW and component to Core - DOM: Core & HTML for someone to take a look at this.

Thanks.

Comment 2

[André Bargull [:anba]]

This is an error in the website itself. The "dayPeriod" option for Intl.DateTimeFormat is a work-in-progress PR from https://github.com/tc39/ecma402/pull/346. The PR defines the following three valid options for the "dayPeriod" option: "narrow", "short", "long".

This error is displayed when navigating to https://www.familysearch.org/en/:

Uncaught RangeError: invalid value "ampm" for option dayPeriod
    <anonymous> https://edge.fscdn.org/assets/components/hf/assets/js/fs/fs-037903e277eacc1f5017a56fa695a9d6.js:1
    <anonymous> https://edge.fscdn.org/assets/components/hf/assets/js/fs/fs-037903e277eacc1f5017a56fa695a9d6.js:1

Deminifying the script gives the following source code:

  let m = {
    weekday: 'short',
    year: 'numeric',
    month: 'short',
    day: 'numeric',
    hour: 'numeric',
    minute: 'numeric',
    dayPeriod: 'ampm',
    hour12: true
  };
  const g = new Intl.DateTimeFormat(r, m);

That clearly shows there's an invalid value ("ampm") specified for the "dayPeriod" option.

Running it in Chrome with --harmony flags enabled gives the same kind of error:

fs-037903e277eacc1f5017a56fa695a9d6.js:1 Uncaught RangeError: Value ampm out of range for Intl.DateTimeFormat options property dayPeriod
    at new DateTimeFormat (<anonymous>)
    at fs-037903e277eacc1f5017a56fa695a9d6.js:1
    at fs-037903e277eacc1f5017a56fa695a9d6.js:1

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Worth to contact the website?

Comment 4

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

(In reply to Olli Pettay [:smaug] from comment #3)

Worth to contact the website?

I reported the issue to the website. Hopefully we will hear back from them.

Bug 1569103 is Nightly-only, we should change the firefox80 status to disabled if there's no plan to have bug 1569103 riding the train 80.

Comment 5

[Ronald Tilby]

The feature is now working on the FamilySearch.org web site using Nightly 80.0a1 (2020-07-24). I believe that FamilySearch corrected their script.