1648812 - The "storage access granted" console log for requestStorageAccess is incorrect

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Steven Englehardt [:englehardt]]

STR:

• In a fresh profile go to https://senglehardt.com/test/dfpi/storage_access_api.html
• Open the console
• In the englehardt-tracker.com iframe click "requestStorageAccess()".

ER: You see the console log Storage access granted for origin “https://englehardt-tracker.com” on “https://senglehardt.com”.

AR: You see the console log Storage access granted for origin “https://englehardt-tracker.com” on “https://englehardt-tracker.com”.

This log results from the call to ReportUnblockingToConsole within CompleteAllowAccessFor. According to the comments at the top of CompleteAllowAccessFor, "aParentContext is the browsing context of the document that calls this API" for requestStorageAccess. Instead of logging aParentContext we need to retrieve the top parent context.

Note that the actual storage access permission seems to be granted to the correct origin, so this is just a logging issue. You can test across two versions of the top-level page:

• https://senglehardt.netlify.app/test/dfpi/storage_access_api.html
• https://senglehardt.com/test/dfpi/storage_access_api.html

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1648812 - Moving ReportUnblockingToConsole to the parent process and fix the console message. r?dimi!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b9cb4e5086f
Moving ReportUnblockingToConsole to the parent process and fix the console message. r=dimi

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6b9cb4e5086f

Comment 4

[Anca Soncutean, Desktop QA]

I’ve reproduced the issue with Fx 79.0a1 (2020-06-26) on Windows 10. I can see the correct message with Fx 81.0a1 (2020-08-09) on Windows 10 and Ubuntu 18.04. But I can see the console message only on Nightly builds. I am not able to trigger any message on Beta. Can I confirm the fix on Beta somehow?