Closed Bug 1648847 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 24364 - Zero |outputs| in AudioWorkletProcessor.process() when reused

Categories

(Core :: Web Audio, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24364 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24364
Details from upstream follow.

Hongchan Choi <hongchan@chromium.org> wrote:

Zero |outputs| in AudioWorkletProcessor.process() when reused

This patch fixes an oversight from https://crrev.com/c/2218702. Now
the sample arrays are reused when possible, so the processor needs to
zero the array content before hading it out to the author script.

Bug: 1099756
Test: third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-process-zero-outputs.https.html
Change-Id: I04ebff6be4a770a0d11a9379b45a124e808506a0
Reviewed-on: https://chromium-review.googlesource.com/2270804
WPT-Export-Revision: 6c77c19fc82965b82d9696351fe7ad5378be7b76

Component: web-platform-tests → Web Audio
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 10 subtests

Status Summary

Firefox

OK : 1
PASS : 7

Chrome

OK : 1
PASS : 4
FAIL : 3

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4a64ef408da [wpt PR 24364] - Zero |outputs| in AudioWorkletProcessor.process() when reused, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.