1648850 - stderr & stdout are not inherited on Windows when mach is using python3 (since 3.7)

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P1)

Description

[Bob Owen (:bobowen)]

Standard logging to the console does not work for the child process with the sandbox turned on.
If you redirect output to a file it does work ... or at least it used to some time ago and then it stopped.

I've finally found some time to track down the issue.
The sandbox inheritance was all working still, but when mozilla-build updated to python 3.7.1 the default for the subprocess.Popen close_fds param changed to True.
So the firefox launcher and main processes never inherit stdout/err.

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1648850: Change Popen close_fds param in process.py to False when pass_thru set. r=glandium!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a91ee62007a
Change Popen close_fds param in process.py to False when pass_thru set. r=glandium

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7a91ee62007a

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bobowen, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Bob Owen (:bobowen)]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #4)

The patch landed in nightly and beta is affected.
:bobowen, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

This is mainly relevant to development builds, so I say wontfix.